Image-based provisioning fails on nvme devices

[Ryan Moe]

fuel-agent uses blockdev --report to gather information about disks on the system. It fails to include nvme devices.

This is the output from blockdev:

[root@bootstrap ~]# blockdev --report
RO RA SSZ BSZ StartSec Size Device
rw 256 512 4096 0 999653638144 /dev/sda
rw 256 512 4096 0 16777216 /dev/sdc

/dev/nvme0n1 is missing from that output even though it's on the system. Classic provisioning (after patching it to handle the partition separator) works fine.

[Ryan Moe (rmoe)]

This was fixed here: https://github.com/karelzak/util-linux/commit/f7541e14c40f291b21016fd4db906fd5755ed87d

[Alexander Gordeev (a-gordeev)]

> Classic provisioning (after patching it to handle the partition separator) works fine.

fuel-agent should be patched too.

[Alexei Sheplyakov (asheplyakov)]

> Probably we just need to upgrade our version of util-linux.

Upgrading core tools (kernel, libc, bash, coreutils, util-linux) is a really bad idea (we are not forking Ubuntu).

A proper fix is to teach fuel-agent to use more sources to collect the block devices data (i.e. examining /proc/partitions, udevadm info --export-db, /sys/block/*)

[Aleksander Mogylchenko (amogylchenko)]

First of all, 6.1 has a huge amount of changes already. And it'll be a big risk to start forking core components in 6.1 on top of already present changes.

I also agree with Alexei that we should avoid forking core components in general (not only in 6.1) as much as possible, and try other solutions (like updating fuel-agent to use what we have, despite the bugs present).

Therefore I'm closing this as won't fix. If there is some great urgency in having this functionality exactly in 6.1 - we should probably make changes in fuel-agent in separate ticket.

[Ryan Moe (rmoe)]

That makes sense, thanks for the explanation. It definitely sounds like fuel-agent is the right place to fix this.

[Vladimir Kozhukalov (kozhukalov)]

It is definitely needs to be fixed in terms of fuel-agent. If this info (nvme disks) is available via other sources like udevadm or /proc/partitions we certainly can parse this inside fuel-agent.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/176735

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/176735
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=81deaea57bbff57b7f08ded2b285e21eafb85a2e
Submitter: Jenkins
Branch: master

commit 81deaea57bbff57b7f08ded2b285e21eafb85a2e
Author: Alexander Gordeev <email address hidden>
Date: Thu Apr 23 16:27:10 2015 +0300

    [IBP] add nvme support

    Get rid of unrelialble 'blockdev' output and switch to 'udevadm info'

    Co-Authored-By: Ryan Moe <email address hidden>
    Related-Change: Ie40afcb29e31c85c2c6021187601d66321fe3a05
    Related-Change: Id2ebcaa5b1332c0e00c54440ee19e6c0cb859e00
    Change-Id: Ibfaeb20994e9a04b34d2423caa55611f2d3153e8
    Closes-Bug: #1436038

[Alexander Gordeev (a-gordeev)]

re-assigning to fuel-python with 'ibp' tag.

[Vitaly Sedelnik (vsedelnik)]

Won't Fix for 6.0-updates as IBP is not relevant for 6.0