Some compute manager tests take excessively long time to complete due to conductor timeouts

[Hans Lindgren]

Some compute manager tests that exercise the exception behavior of methods combined with using a somewhat real instance parameter when doing so take very long time to complete. This happens if the method being tested has the @revert_task_state decorator because it will try to update the instance using a conductor call when there is no conductor service listening.

By setting the conductor use_local flag for those tests I am able to reduce the total test time with 4 full minutes when run locally.

[Sean Dague (sdague)]

Can you provide some specific examples here? Or is this just a tracking bug for patches you'll be pushing?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167184

[Hans Lindgren (hanlind)]

I'm specifically taking about the following tests, all in nova.tests.unit.compute.test_compute_mgr.ComputeManagerUnitTestCase:

test_attach_interface_failure
test_set_admin_password_bad_state
test_swap_volume_volume_api_usage

All can be seen in recent gate runs where these tests are the ones taking most time.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167184
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ed2c7a607a5fe7bb71ef574e4bc3cfb8920ddd47
Submitter: Jenkins
Branch: master

commit ed2c7a607a5fe7bb71ef574e4bc3cfb8920ddd47
Author: Hans Lindgren <email address hidden>
Date: Tue Mar 24 12:34:32 2015 +0100

    Set conductor use_local flag in compute manager tests

    Some compute manager tests that exercise the exception behavior of
    methods combined with using a somewhat real instance parameter when
    doing so take very long time to complete(>60s). This happens if the
    method being tested has the @revert_task_state decorator because it
    will try to update the instance using a conductor call when there is
    no conductor service listening.

    By setting the use_local flag, these tests no longer experience such
    timeouts and total test time is reduced by minutes.

    Change-Id: I4f5272f5b39d53ad7e868cc8c91a793851ab4387
    Closes-Bug: #1435803