osx_build_wx.sh does not patch wxwidgets with included Yosemite-specific patch

[Rob Caldwell]

The wxWidgets patch file patches/wxwidgets-3.0.2_macosx_yosemite.patch exists but is never used by the osx_build_wx.sh script.

Attached is a patch that tests the minor version number given by the "OS X target version" argument for a value of 10 (Yosemite) or higher and applies the patch if true. E.g. The argument 10.10 uses the Yosemite-specific patch while 10.9 will not.

[Adam Wolf (adamwolf)]

Hi Rob,

As far as I know, it doesn't hurt to always patch OS X wxwidgets with that patch. I haven't deeply investigated it. What do you think?

[Rob Caldwell (rob-e-caldwell)]

Hi Adam,

I believe that applying wxwidgets-3.0.2_macosx_yosemite.patch to systems not running Yosemite will break compilation. However upon closer examination of this problem it seems that a proper patch has very recently been committed to the wxWidgets WX_3_0_BRANCH.

So I prepared another patch that removes patches/wxwidgets-3.0.2_macosx_yosemite.patch, adds patches/wxwidgets-3.0.2_macosx_bug_16329.patch (from #16329) to replace it, and modifies scripts/osx_build_wx.sh to apply the latter regardless of the OS X version.

More details about this problem can be found here: http://trac.wxwidgets.org/ticket/16329

Rob

[xzcvczx (xzcvczx)]

as the file has been removed, closing bug