trigger security group refresh gives 'dict' object has no attribute 'uuid'

[Dan Smith]

During trigger_rules_refresh(), we get this from compute manager:

2015-03-23 03:50:49.677 ERROR oslo_messaging.rpc.dispatcher [req-117e72d4-8c12-4805-9c65-695b62fad491 alt_demo alt_demo] Exception during message handling: 'dict' object has no attribute 'uuid'
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher Traceback (most recent call last):
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 142, in _dispatch_and_reply
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher executor_callback))
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 186, in _dispatch
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher executor_callback)
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 130, in _do_dispatch
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher result = func(ctxt, **new_args)
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/exception.py", line 88, in wrapped
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher payload)
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 85, in __exit__
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/exception.py", line 71, in wrapped
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher return f(self, context, *args, **kw)
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher File "/opt/stack/new/nova/nova/compute/manager.py", line 1301, in refresh_instance_security_rules
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher @utils.synchronized(instance.uuid)
2015-03-23 03:50:49.677 32448 TRACE oslo_messaging.rpc.dispatcher AttributeError: 'dict' object has no attribute 'uuid'

This happens because we're passing non-object instances to refresh_instance_security_rules()

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167023

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167023
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ed21227cbc9b9c16275f4efc438fe0170c1e505d
Submitter: Jenkins
Branch: master

commit ed21227cbc9b9c16275f4efc438fe0170c1e505d
Author: Dan Smith <email address hidden>
Date: Mon Mar 23 15:16:16 2015 -0700

    Make refresh_instance_security_rules() handle non-object instances

    We have code in compute/api that still passes non-object instance dicts
    over RPC to compute manager's refresh_instance_security_rules(). For now,
    we can just decorate this with object_compat.

    Change-Id: I0474aa8b14c897f66095ec11ca0329309bd37b5d
    Closes-Bug: #1435586