[fuel-ci] syntax check script does not work as expected for removed modules

Bug #1435401 reported by Aleksandr Didenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Critical
Aleksandr Didenko
6.1.x
Fix Released
Critical
Aleksandr Didenko

Bug Description

We can fail to "pushd" into removed module and run syntax check inside 'fuel-library' globally.

https://review.openstack.org/#/c/165766/ patch fails to pass fuel_review_syntax_check https://fuel-jenkins.mirantis.com/job/fuellib_review_syntax_check/7787/consoleFull because of this issue.

Tags: devops fuel-ci
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/166906

Changed in fuel:
status: New → In Progress
tags: added: devops
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/166906
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=f5d0e15f48d4f6ecec09df87e031474cef734a17
Submitter: Jenkins
Branch: master

commit f5d0e15f48d4f6ecec09df87e031474cef734a17
Author: Aleksandr Didenko <email address hidden>
Date: Mon Mar 23 17:59:01 2015 +0200

    Don't run syntax/unit tests for removed modules

    We're running syntax and unit tests for changed modules only.

    But for removed modules, we fail to 'pushd $mod' and thus run test
    functions inside current working directory, which is not correct.

    We should test if changed module dir exists before trying to run
    tests for it.

    Fuel-CI: disable

    Change-Id: If1ab6850943b7aed7a48479625d8daa0243594f6
    Closes-bug: #1435401

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.