export locations are not set as deleted in DB after share deletion

Bug #1435313 reported by Valeriy Ponomaryov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Valeriy Ponomaryov

Bug Description

Steps to reproduce:

1) Create share

2) List export locations for share (using SQL query):

+----+---------------------+---------------------+------------+---------+---------------------------------------------------------------+--------------------------------------+
| id | created_at | updated_at | deleted_at | deleted | path | share_id |
+----+---------------------+---------------------+------------+---------+---------------------------------------------------------------+--------------------------------------+
| 1 | 2015-03-23 12:18:23 | 2015-03-23 12:18:23 | NULL | 0 | 10.254.0.3:/shares/share-8cd0619b-1e86-4085-8e2f-ed824192e10d | 8cd0619b-1e86-4085-8e2f-ed824192e10d |
+----+---------------------+---------------------+------------+---------+---------------------------------------------------------------+--------------------------------------+

3) delete share

4) List export locations for share after its deletion:

+----+---------------------+---------------------+------------+---------+---------------------------------------------------------------+--------------------------------------+
| id | created_at | updated_at | deleted_at | deleted | path | share_id |
+----+---------------------+---------------------+------------+---------+---------------------------------------------------------------+--------------------------------------+
| 1 | 2015-03-23 12:18:23 | 2015-03-23 12:18:23 | NULL | 0 | 10.254.0.3:/shares/share-8cd0619b-1e86-4085-8e2f-ed824192e10d | 8cd0619b-1e86-4085-8e2f-ed824192e10d |
+----+---------------------+---------------------+------------+---------+---------------------------------------------------------------+--------------------------------------+

But it is expected to be soft deleted, so, fields "deleted_at" and "deleted" are not updated at all in table "export_locations".

Tags: db
description: updated
tags: added: db
Changed in manila:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
milestone: none → kilo-rc1
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/168413

Revision history for this message
Luis Pabón (lpabon) wrote :

How do I do step do. I am not sure how to send the sql query.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/168413
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=5ee705b0051480837da740212113b34e759bfe75
Submitter: Jenkins
Branch: master

commit 5ee705b0051480837da740212113b34e759bfe75
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Mar 27 18:41:49 2015 +0200

    Fix deletion of export locations

    Export locations stored in separate table are not deleted. Never.
    Fix it for two cases: when share deletion is performed and export locations
    update operation that 'share driver's do.

    Change-Id: I7b66c8843647862e398e71898ac258f07f264e3a
    Closes-Bug: #1435313

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.