test_neutron_autoscaling integraton test is misleading and needs improvement

Bug #1435285 reported by Pavlo Shchelokovskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Pavlo Shchelokovskyy

Bug Description

The scenario/test_neutron_autoscaling is actually not testing autoscaling per se as it simply updates the size of the autoscaling group manually via stack-update. Besides, it uses full-blown servers to create, which is not needed in such test scenario (RandomStrings might have sufficed).

Ideally we could combine the test_neutron_autoscaling with test_neutron_loadbalancer to cover the following very common usage scenario:

1) create an autoscaling group with 1 app server behind a loadbalancer
2) check for single distinctive response from loadbalanced app
3) trigger autoscaling with resource signal
4) check that now we have 2 distinctive responses from loadbalanced app

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to heat (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/166792

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to heat (master)

Reviewed: https://review.openstack.org/166792
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=0d29640228f02df2bf7be09ac9ca8188b17e4538
Submitter: Jenkins
Branch: master

commit 0d29640228f02df2bf7be09ac9ca8188b17e4538
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Mon Mar 23 12:01:25 2015 +0000

    Add minimal_instance_type config option

    for integration tests. Use a flavor similar to m1.micro for that.
    It is enough to start both minimal and functional tests images with no
    serious payload and should decrease the amount of RAM consumed by VMs
    in corresponding tests four-fold.

    Change-Id: I378b5a3cde020176ac45ebf8d05bd13278861a4e
    Related-Bug: #1435285

Angus Salkeld (asalkeld)
Changed in heat:
status: New → Triaged
Changed in heat:
status: Triaged → In Progress
Changed in heat:
status: In Progress → Triaged
Changed in heat:
status: Triaged → In Progress
Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote :

somehow Gerrit+LP does not register the actual patch, it is already long on review

https://review.openstack.org/#/c/165944/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/165944
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1bc886c89d54fb0b706f724fa202d61604b14562
Submitter: Jenkins
Branch: master

commit 1bc886c89d54fb0b706f724fa202d61604b14562
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Thu Mar 19 17:54:52 2015 +0000

    Merge Neutron AutoScaling and LoadBalancer tests

    The tested use case is an autoscaling group of web app servers
    behind a loadbalancer.

    Test template was rewritten to use AutoScalingGroup, wait conditions and
    outputs, so no other client than heat one is used.
    Now there is no need to check for VM connectivity,
    as stack/resources status COMPLETE now quite reliably means
    that the listening servers are running.

    This patch should probably also help with narrowing down the causes of
    bug 1437203, since it does not checks instance connectivity with SSH.

    Change-Id: Iec8e8061f9ab3f3841fa221722b7b7805760cdf7
    Related-Bug: #1437203
    Closes-Bug: #1435285

Changed in heat:
status: In Progress → Fix Committed
Changed in heat:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-3 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.