[Launch Instance Fix] Use Magic Search in each step instead of basic search bar

Bug #1434710 reported by Kelly Domico
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Matt Borland

Bug Description

The source, flavor, network and access & security steps in the Launch Instance workflow currently uses a basic search bar (Smart-Table filtering). Use Magic Search instead for client side faceted search.

Tags: angularjs
Changed in horizon:
assignee: nobody → Kelly Domico (kelly-domico)
Changed in horizon:
status: New → In Progress
Tyr Johanson (tyr-6)
tags: added: ng-subteam-nodefault
Changed in horizon:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/201581

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/201582

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Kelly Domico (<email address hidden>) on branch: master
Review: https://review.openstack.org/166080
Reason: Changes in https://review.openstack.org/#/c/201582/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/202319

Changed in horizon:
assignee: Kelly Domico (kelly-domico) → Rajat (rajatv)
Changed in horizon:
assignee: Rajat (rajatv) → Kelly Domico (kelly-domico)
Changed in horizon:
assignee: Kelly Domico (kelly-domico) → Rajat (rajatv)
Changed in horizon:
assignee: Rajat (rajatv) → Kelly Domico (kelly-domico)
Changed in horizon:
assignee: Kelly Domico (kelly-domico) → Rajat (rajatv)
Changed in horizon:
assignee: Rajat (rajatv) → Kelly Domico (kelly-domico)
Changed in horizon:
assignee: Kelly Domico (kelly-domico) → Rajat Vig (rajatv)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/201581
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cf4dcc75317736ad0fa859731abecb26f5f55211
Submitter: Jenkins
Branch: master

commit cf4dcc75317736ad0fa859731abecb26f5f55211
Author: Kelly Domico <email address hidden>
Date: Mon Jul 13 16:14:43 2015 -0700

    Client-side Magic Search

    This patch provides a client side magic search bar as a directive.
    Users can filter a table with faceted search or free text search.
    This search bar requires Smart-Table.

    Co-Authored-By: Randy Bertram <email address hidden>
    Co-Authored-By: Aaron Sahlin <email address hidden>

    Change-Id: I7e41da5b7e8a4c9b68e96e80b2daebf02aba7662
    Partial-Bug: #1434710

Changed in horizon:
assignee: Rajat Vig (rajatv) → Kelly Domico (kelly-domico)
Changed in horizon:
assignee: Kelly Domico (kelly-domico) → Rajat Vig (rajatv)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Rajat Vig (<email address hidden>) on branch: master
Review: https://review.openstack.org/202319
Reason: Merged into parent

Changed in horizon:
assignee: Rajat Vig (rajatv) → Matt Borland (palecrow)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/201582
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5ee8de73e2a1c702a5dfc80fc817b50b224c81b2
Submitter: Jenkins
Branch: master

commit 5ee8de73e2a1c702a5dfc80fc817b50b224c81b2
Author: Rajat Vig <email address hidden>
Date: Wed Sep 2 09:16:30 2015 -0700

    [Launch Instance Fix] Magic Search in new Launch Instance

    Currently implemented in the "Select Source", Network and
    "Select Flavor" step in the Launch Instane workflow.

    Co-Authored-By: Rajat Vig<email address hidden>

    Change-Id: I5e195bfcf7fe3367576089b23cc08b40c2c36b09
    Partial-Bug: #1434710

tags: added: angularjs
removed: ng-subteam-nodefault
Changed in horizon:
milestone: none → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/317554

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/317554
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=26359bd00f38452eb7551da55e296680aac38e34
Submitter: Jenkins
Branch: master

commit 26359bd00f38452eb7551da55e296680aac38e34
Author: Matt Borland <email address hidden>
Date: Tue May 17 09:04:30 2016 -0600

    Use Magic-Search for Security Groups step in Launch Instance

    Security Groups was the last table in the stanaard Launch Instance steps
    that didn't use Magic Search for filtering. This patch establishes the
    use of Magic Search and also removes the search bar from the table to
    promote accessibility.

    The filters are only for Name and Description right now, but this allows
    additional filters to be added as necessary.

    Change-Id: I5e6098752d1b1d5c9736c103796b533d656092a6
    Closes-Bug: 1434710

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → newton-2
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b2

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.