payload_content_encoding is ignored when content_type is none or empty

Bug #1434652 reported by Thomas Dinkjian
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-barbicanclient
Fix Released
Medium
Douglas Mendizábal

Bug Description

When submitting a secret with the following payload:
secret_create_defaults_data = {
    "name": "AES key",
    "expiration": "2018-02-28T19:14:44.180394",
    "algorithm": "aes",
    "bit_length": 256,
    "mode": "cbc",
    "payload": "gF6+lLoF3ohA9aPRpt+6bQ=="
    "payload_content_type": None(or "")
    "payload_content_encoding": "base64",
}

The secret is created successfully because the encoding gets ignored.
This should return a 400 error since the user specified incorrect information.

Changed in python-barbicanclient:
status: New → Confirmed
Revision history for this message
Chelsea Winfree (chelsea-winfree) wrote :
Changed in python-barbicanclient:
status: Confirmed → In Progress
Changed in python-barbicanclient:
importance: Undecided → Medium
milestone: none → 3.0.3
assignee: nobody → Douglas Mendizábal (dougmendizabal)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-barbicanclient (master)

Reviewed: https://review.openstack.org/168163
Committed: https://git.openstack.org/cgit/openstack/python-barbicanclient/commit/?id=06709099debd41ef9c75a4c6f24c3eb1c14eb8a5
Submitter: Jenkins
Branch: master

commit 06709099debd41ef9c75a4c6f24c3eb1c14eb8a5
Author: Douglas Mendizábal <email address hidden>
Date: Thu Mar 26 16:43:36 2015 -0500

    Don't ignore payload_content_encoding if set

    Even though setting the payload_content_encoding is deprecated, we
    should not ignore it if set. Uncommented functional tests that found
    this bug. Removed a couple of tests because they were incorrect.

    Change-Id: Idd294909ddd622d3baf2e8df92c94f8f52ac5799
    Closes-Bug: #1434652

Changed in python-barbicanclient:
status: In Progress → Fix Committed
Changed in python-barbicanclient:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-barbicanclient 3.0.3

This issue was fixed in the openstack/python-barbicanclient 3.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.