share server can not be deleted if hung in transitional state

[Valeriy Ponomaryov]

For the moment, we have no possibility to delete share-server that is hung in some transitional state like "creating" or "deleting".

It can hang in it if manila-share failed to write to DB end-state for some reason.

Also, share server hung in "creating" state is taken for each new share, so, it causes chain of errors and shares are no more able to be run on one specific share-network.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/170528

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170528
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=815e2c95acc402847bb497365ea5caba608fd8cc
Submitter: Jenkins
Branch: master

commit 815e2c95acc402847bb497365ea5caba608fd8cc
Author: Igor Malinovskiy <email address hidden>
Date: Fri Apr 10 11:04:03 2015 +0300

    Prevent hanging share server in 'creating' state

    Currently, share server can hang in 'creating' state
    because except block does not take into account possibility
    of error occurring in share_server_backend_details_set() method.

    - Write server details one by one with individual error handling
    - Move call of share_server_update() to 'finally' block to
    prevent hanging share server in 'creating' state

    Change-Id: I77bdf62fbaa66a226944fb0c07fb2b8dfaf11a0e
    Closes-Bug: #1434563