Unmanage API allows schedule unmanaging of share that could not be managed

Bug #1434511 reported by Valeriy Ponomaryov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Valeriy Ponomaryov

Bug Description

For the moment "manage/unmanage" operation is allowed only for driver mode without handling of share servers.

But "unmanage" API allows us to schedule unamanging of share that was created on top of share server. It leads to change of sahre status "UNMANAGE_ERROR". It should be restricted on API side.

Tags: api unmanage
tags: added: api unmanage
Changed in manila:
importance: Undecided → High
milestone: none → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/166348

Changed in manila:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/166348
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=a0703047d52b700ef8917996dd45ca3fb16e5f5d
Submitter: Jenkins
Branch: master

commit a0703047d52b700ef8917996dd45ca3fb16e5f5d
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Mar 20 20:58:17 2015 +0200

    Add share state verification for API 'unmanage'

    Shares with transitional states like 'creating' or 'deleting' should not be
    allowed to be unmanaged.
    For the moment "manage/unmanage" operation is allowed only for driver mode
    without handling of share servers. So, API operations against shares created
    on top of share servers should be restricted on API level.

    Change-Id: I73b554448eadcb96ef00f44535014e14dea91472
    Closes-Bug: #1434642
    Closes-Bug: #1434511

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.