Fuel allow to add wrong repo

Bug #1434418 reported by Denis Klepikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Won't Fix
Medium
Unassigned
6.1.x
Won't Fix
Medium
Unassigned

Bug Description

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.1"
  api: "1.0"
  build_number: "207"
  build_id: "2015-03-19_11-00-33"
  nailgun_sha: "7b4350afb2a13eba11c710aa30e6441ec2993fd5"
  python-fuelclient_sha: "5260d08776c981d3bd96b0b1d57efaeafeb06326"
  astute_sha: "f7a93309473ca7673a6593f26f80a9d4fc2bac24"
  fuellib_sha: "4fd580ae876a9565266807a73a4d4d7f02df9e23"
  ostf_sha: "9435ec9f0aaf5bb8b9773347af871ab281b9ae78"
  fuelmain_sha: "fbfe367850a7e902d67d5ba05bfb9ed937a38dae"

Fuel allows to add custom repo not in FQDN format, and replace default MOS repo
It does not check repo for availability, even no check does repo exist.

Revision history for this message
Denis Klepikov (dklepikov) wrote :
Changed in fuel:
assignee: nobody → Fuel UI Team (fuel-ui)
description: updated
Revision history for this message
Alexandra Morozova (astepanchuk) wrote :

The verification should be done by backend

Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

We don't have backend validation for many parts in Fuel. So, it's out of scope for this release. But we have to improve our validation on UI for sure (it shouldn't be a big deal).

Regarding repo availability - there's a plan to add a simple connectivity check via master node, though it won't show us the real picture. In order to perform the real check we should be able to configure public network on our bootstrap nodes and it's a big deal.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/170894

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

I suggest not to fix it by modifiying the regexp. It's really hard to construct a regexp to cover all the cases: https://mathiasbynens.be/demo/url-regex And there also chances that it will not allow valid URL. So I suggest to stick with the current version of the regexp. To solve this issue completely, there should be connectivity check.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Vitaly Kramskikh (<email address hidden>) on branch: master
Review: https://review.openstack.org/170894
Reason: I think we should not modify the regexp, explanation is in the LP bug

Changed in fuel:
assignee: Julia Aranovich (jkirnosova) → nobody
status: In Progress → New
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.