Instance percentage couldn't show in the new launch instance form

Bug #1434407 reported by Liyingjun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Liyingjun

Bug Description

When the decimal point is too long, the instance percentage will be not shown right. see attachment.

Revision history for this message
Liyingjun (liyingjun) wrote :
Changed in horizon:
assignee: nobody → Liyingjun (liyingjun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/166121

Changed in horizon:
status: New → In Progress
Revision history for this message
Brian Tully (brian-tully) wrote :

Thanks for noticing this. Actually, according to the intended design from the mockups, there should not be any decimal points for the donut chart labels that show usage %. When we add 2 decimal points it breaks the intended design (the label is too big for the donut chart). Instead of explicitly setting 2 decimal places by using .toFixed(2) we should instead set no decimal places and round by using .toFixed()

Thanks! :)

Changed in horizon:
milestone: none → kilo-rc1
importance: Undecided → Low
Changed in horizon:
assignee: Liyingjun (liyingjun) → David Lyle (david-lyle)
Changed in horizon:
assignee: David Lyle (david-lyle) → Liyingjun (liyingjun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/166121
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=db0d15c1235b25bc10a9791b9c71816c928e3656
Submitter: Jenkins
Branch: master

commit db0d15c1235b25bc10a9791b9c71816c928e3656
Author: liyingjun <email address hidden>
Date: Fri Mar 20 14:57:27 2015 +0800

    [Launch Instance fix] Fix decimal point

    When the decimal point is too long, the instance percentage will be not
    shown right in the instance detail form. Restrict decimal point to 2.

    Change-Id: I126853251b0f9bff62c8edbb48df9146436b0b49
    Closes-bug: #1434407

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.