[Launch Instance Fix] Fix donut chart title data and standardize design

Bug #1434303 reported by Tyr Johanson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Brian Tully

Bug Description

Currently, each step passes in settings for the donut charts. These can be standardized in the chart itself, and overrides removed from each step. In addition we can add constants to the charts for label names (so that they may be translated) and css classes. These can then be leveraged for validation UX. In addition, there is a bug where the chart title shows (# Max), however this # is not really the Max limit and instead is a sum of usage, added and available. We should add a maxLimit property to the chartData object that when passed will ensure it stays intact and therefore can be used for validation. If no maxLimit is specified, the current chart logic can be used to sum the usage, added and available items, but we should change the title to show (# Total) instead of (# Max)

Tags: ng-subteam
Changed in horizon:
assignee: nobody → Brian Tully (brian-tully)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167377

Changed in horizon:
status: New → In Progress
summary: - [Launch Instance Fix] Make donut chart styles common for all steps
+ [Launch Instance Fix] Fix donut chart title data and standardize design
description: updated
Tyr Johanson (tyr-6)
tags: added: ng-subteam
Changed in horizon:
assignee: Brian Tully (brian-tully) → Kelly Domico (kelly-domico)
Changed in horizon:
assignee: Kelly Domico (kelly-domico) → Brian Tully (brian-tully)
Changed in horizon:
assignee: Brian Tully (brian-tully) → Kelly Domico (kelly-domico)
Changed in horizon:
assignee: Kelly Domico (kelly-domico) → Brian Tully (brian-tully-k)
Changed in horizon:
importance: Undecided → Low
Changed in horizon:
assignee: Brian Tully (brian-tully-k) → Brian Tully (brian-tully)
Changed in horizon:
milestone: none → liberty-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/167377
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=632200eafffc4896510f6b7a54aca768dfb78a94
Submitter: Jenkins
Branch: master

commit 632200eafffc4896510f6b7a54aca768dfb78a94
Author: Brian Tully <email address hidden>
Date: Fri Apr 3 06:43:15 2015 -0400

    Fix donut chart title data and standardize design

    This patch updates the chart widget with default styling for donut
    charts and labels. It also updates CSS to more closely match mockups.
    The patch also adds a constant for quotaChartDefaults for label text
    and colors. This patch also fixes a bug where the chart title would
    show more than what was available rather than max. A 'maxLimit'
    property was added to accommodate validity. This patch also adds
    validation UI to warn user when over quota.

    Closes-Bug: 1434303

    Change-Id: I552a1a28fce755119eb91bf6afce8494e0aa1791

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.