Invalid stack creation hangs due to Data too long for column 'status_reason'

Bug #1434290 reported by Moshe Elisha
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Angus Salkeld

Bug Description

Hey,

In heat/engine/stack.py state_set method, the reason is used as is when invoking "stack.update_and_save" and it is not truncated.

I understand that making status_reason a longtext instead of varchar(256) might be late for Kilo release. Please consider it for next release.

Logs and stack template attached in zip.

This is similar to https://bugs.launchpad.net/heat/+bug/1312815 - opening a new bug as requested.

Reproduced in the latest DevStack code (Kilo).

Revision history for this message
Moshe Elisha (melisha) wrote :
Changed in heat:
status: New → Triaged
importance: Undecided → High
milestone: none → kilo-rc1
Changed in heat:
assignee: nobody → Deliang Fan (vanderliang)
Revision history for this message
Steve Baker (steve-stevebaker) wrote :

On second thoughts, maybe we can consider switching to longtext now

Revision history for this message
Moshe Elisha (melisha) wrote :

That would be great!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167102

Changed in heat:
assignee: Deliang Fan (vanderliang) → Angus Salkeld (asalkeld)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/167102
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=60fe4063947848d83ab69d246ed8c14e9039caf7
Submitter: Jenkins
Branch: master

commit 60fe4063947848d83ab69d246ed8c14e9039caf7
Author: Angus Salkeld <email address hidden>
Date: Wed Mar 25 13:47:17 2015 +1000

    Make the status_reason field Text instead of String(255)

    Change-Id: I8eaaa7bc55afff16d16bbd9d41b5522f02f83071
    Closes-bug: 1434290

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.