Fix flaky unit test in unittests/mgmt/test_models.py

Bug #1434258 reported by Nikhil Manchanda
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Critical
Nikhil Manchanda

Bug Description

There's a flaky assert in one of the unit tests in TestMgmtInstanceDeleted.

2015-03-19 18:57:43.922 | ======================================================================
2015-03-19 18:57:43.923 | FAIL: mgmt.test_models.TestMgmtInstanceDeleted.test_show_deleted_mgmt_instances
2015-03-19 18:57:43.923 | tags: worker-7
2015-03-19 18:57:43.923 | ----------------------------------------------------------------------
2015-03-19 18:57:43.924 | Traceback (most recent call last):
2015-03-19 18:57:43.924 | File "/home/jenkins/workspace/gate-trove-python27/trove/tests/unittests/mgmt/test_models.py", line 408, in test_show_deleted_mgmt_instances
2015-03-19 18:57:43.924 | db_infos_deleted.count())
2015-03-19 18:57:43.925 | File "/home/jenkins/workspace/gate-trove-python27/.tox/py27/local/lib/python2.7/site-packages/unittest2/case.py", line 678, in assertTrue
2015-03-19 18:57:43.925 | raise self.failureException(msg)
2015-03-19 18:57:43.925 | AssertionError: False is not true
2015-03-19 18:57:43.925 | Ran 849 tests in 12.161s
2015-03-19 18:57:43.926 | FAILED (id=0, failures=1, skips=1)
2015-03-19 18:57:43.927 | error: testr failed (1)
2015-03-19 18:57:43.947 | ERROR: InvocationError: '/home/jenkins/workspace/gate-trove-python27/.tox/py27/bin/python setup.py testr --slowest'
2015-03-19 18:57:43.948 | py27 runtests: commands[2] | /home/jenkins/workspace/gate-trove-python27/.tox/py27/bin/python generate_examples.py

Changed in trove:
importance: Undecided → Critical
status: New → Triaged
assignee: nobody → Nikhil Manchanda (slicknik)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165995

Changed in trove:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/165995
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=5e3c0fbb77a4990ea3dea11e9add4d9b5c382308
Submitter: Jenkins
Branch: master

commit 5e3c0fbb77a4990ea3dea11e9add4d9b5c382308
Author: Nikhil Manchanda <email address hidden>
Date: Thu Mar 19 12:56:56 2015 -0700

    Remove flaky assert from TestMgmtInstanceDeleted test

    There is a flaky assert that fails occasionally in the
    mgmt.test_models.TestMgmtInstanceDeleted.test_show_deleted_mgmt_instances
    unit test due to a what seems to be a race condition in the unit tests
    that run in parallel. Commenting out this flaky assert to unblock gate
    issues for now.

    Change-Id: Ib7b5c33f49bc70427f84bd69bbcb7420b5f32d9e
    Partial-bug: 1434258

Changed in trove:
milestone: none → kilo-rc1
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.