Add missing try/except to extension_supported call in Ports

Bug #1434116 reported by Rob Cresswell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Ankur

Bug Description

The Ports forms make Neutron api calls ('is_extension_supported') without proper Exception handling

Tags: neutron
Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
Changed in horizon:
milestone: none → next
milestone: next → kilo-rc1
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
status: New → Confirmed
David Lyle (david-lyle)
Changed in horizon:
milestone: kilo-rc1 → liberty-1
tags: added: kilo-rc-potential
David Lyle (david-lyle)
tags: added: neutron
removed: kilo-rc-potential
Changed in horizon:
milestone: liberty-1 → liberty-2
Changed in horizon:
milestone: liberty-2 → liberty-3
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → liberty-rc1
David Lyle (david-lyle)
Changed in horizon:
milestone: liberty-rc1 → next
Revision history for this message
Itxaka Serrano (itxaka) wrote :

Seems that this affects other components.

Im wondering, wouldnt it be easier to modify the actual api.neutron.is_extension_supported call with a try/catch + logging, returns False if an Exception is raised?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/324095

Changed in horizon:
assignee: Rob Cresswell (robcresswell) → Ankur (ankur-gupta-f)
status: Confirmed → In Progress
Changed in horizon:
milestone: next → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/324095
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c704623cceb2122814a6933d9aac47a845ef9bf9
Submitter: Jenkins
Branch: master

commit c704623cceb2122814a6933d9aac47a845ef9bf9
Author: Ankur Gupta <email address hidden>
Date: Wed Jun 1 15:22:34 2016 -0500

    Add Try/Exception to Extension Supported call in Ports

    The port form makes 2 Neutron api calls ('is_extension_supported')
    without proper exception handling.

    Placed each call within try/except block. For admin and project
    dashboards.

    Potential solution posed by itxakaserrano is to make the actual
    Neutron api call try/catch with logging and return the
    Exception if raised.

    Change-Id: I357175e4be43b09dfa74ffe8a1d2c8c7ea49ce93
    Closes-Bug: #1434116

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b2

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.