Refactor logic for running Ceph pre-delete task in server/dispatcher.rb

[Ryan Moe]

A temporary workaround to only run the Ceph OSD check task was added in https://review.openstack.org/#/c/165254/. It should be refactored to not rely on checking 'respond_to'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/165946

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/165949

[Dmitry Borodaenko (angdraug)]

Resolution blocked by review https://review.openstack.org/165946 in fuel-astute, reassigned to Vladimir since Ryan is unavailable until 4/16.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165949
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=bcc1584283b3f218743b5702ee79141f400756c5
Submitter: Jenkins
Branch: master

commit bcc1584283b3f218743b5702ee79141f400756c5
Author: Ryan Moe <email address hidden>
Date: Thu Mar 19 11:06:11 2015 -0700

    Add new parameter in DeletionTask to run Ceph check

    DeletionTask.execute now has an additional parameter 'check_ceph'.
    When this parameter is True it will run a check to ensure there
    is no Ceph data prior to deleting a node.

    Change-Id: I818f29ae4e0f28bf6ddc97f0975d59d6def7c1a4
    Related-bug: #1434082

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165946
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=da11a7d516a620955f8f112648e2b32a2ab020ad
Submitter: Jenkins
Branch: master

commit da11a7d516a620955f8f112648e2b32a2ab020ad
Author: Ryan Moe <email address hidden>
Date: Thu Mar 19 10:59:10 2015 -0700

    Add optional Ceph check when deleting nodes

    Nailgun calls the same dispatcher method for node and cluster
    deletion tasks. Checking for Ceph data in the cluster should
    only happen when deleting nodes. This behavior is controlled by
    a new parameter check_ceph.

    Depends-On: I818f29ae4e0f28bf6ddc97f0975d59d6def7c1a4
    Change-Id: I1bc78e12e1ece879ada0dcffdfb44d503c1d0813
    Closes-bug: #1434082

[Mykola Golub (mgolub)]

Verified on

{
    "build_id": "2015-05-19_10-05-51",
    "build_number": "437",
    "auth_required": true,
    "fuel-ostf_sha": "9ce1800749081780b8b2a4a7eab6586583ffaf33",
    "fuel-library_sha": "2814c51668f487e97e1449b078bad1942421e6b9",
    "nailgun_sha": "593c99f2b46cf52b2be6c7c6e182b6ba9f2232cd",
    "openstack_version": "2014.2.2-6.1",
    "production": "docker",
    "api": "1.0",
    "python-fuelclient_sha": "e19f1b65792f84c4a18b5a9473f85ef3ba172fce",
    "astute_sha": "96801c5bccb14aa3f2a0d7f27f4a4b6dd2b4a548",
    "fuelmain_sha": "68796aeaa7b669e68bc0976ffd616709c937187a",
    "feature_groups": [
        "mirantis"
    ],
    "release": "6.1",
    "release_versions": {
        "2014.2.2-6.1": {
            "VERSION": {
                "build_id": "2015-05-19_10-05-51",
                "build_number": "437",
                "fuel-library_sha": "2814c51668f487e97e1449b078bad1942421e6b9",
                "nailgun_sha": "593c99f2b46cf52b2be6c7c6e182b6ba9f2232cd",
                "fuel-ostf_sha": "9ce1800749081780b8b2a4a7eab6586583ffaf33",
                "production": "docker",
                "api": "1.0",
                "python-fuelclient_sha": "e19f1b65792f84c4a18b5a9473f85ef3ba172fce",
                "astute_sha": "96801c5bccb14aa3f2a0d7f27f4a4b6dd2b4a548",
                "fuelmain_sha": "68796aeaa7b669e68bc0976ffd616709c937187a",
                "feature_groups": [
                    "mirantis"
                ],
                "release": "6.1",
                "openstack_version": "2014.2.2-6.1"
            }
        }
    }
}

using Juno on Ubuntu 14.04.1.

It works as expected: fuel does not allow to delete a node until OSDs are manually removed from ceph cluster; it is possible to delete the whole cluster.