Invalid tags are skipped instead of raising an exception

Bug #1433962 reported by Kamil Rykowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Undecided
Kamil Rykowski

Bug Description

As Mike suggested - https://review.openstack.org/#/c/165391/ - passing invalid value for tag when filtering the image list should raise an exception instead of skipping "bad" values.

Add proper test(s) to cover such scenario.

Tags: metadef
Changed in python-glanceclient:
assignee: nobody → Kamil Rykowski (kamil-rykowski)
status: New → In Progress
tags: added: metadef
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/165391
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=2c08b40bf08a7dfbe8aa3a7b9a2648010b51330b
Submitter: Jenkins
Branch: master

commit 2c08b40bf08a7dfbe8aa3a7b9a2648010b51330b
Author: Kamil Rykowski <email address hidden>
Date: Wed Mar 18 13:29:20 2015 +0100

    Validate tag name when filtering for images

    Right now all invalid tags are skipped when filtering for image list. We
    should change this behaviour to raise an exception when invalid tag
    value is provided.

    Additionally remove misplaced `pass` from one of the tests.

    Closes-Bug: 1433962
    Change-Id: If5148608a70ee019697ea2dcb84e19a53222d596

Changed in python-glanceclient:
status: In Progress → Fix Committed
Changed in python-glanceclient:
milestone: none → 1.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.