Horizon crashes which user click the "Confirm resize" action multiple times while an instance is resizing

Bug #1433849 reported by Kahou Lei
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Justin Pomeroy
Kilo
Fix Released
Undecided
Unassigned

Bug Description

Steps to reproduce:

1. Boot an instance
2. Resize that instance
3. When the instance is in Confirm resize state, click the "Confirm resize" action.
4. After the action is clicked once, the "Confirm resize" action still shows up, click it couple times.
5. You will see Horizon crashes with the following error:

Cannot 'confirmResize' instance d1ba0033-4ce7-431d-a9dc-754fe0631fef while it is in vm_state active (HTTP 409)

Revision history for this message
zhu zhu (zhuzhubj) wrote :

Which hypervisor are you using?

Revision history for this message
Doug Fish (drfish) wrote :

I was able to reproduce this on devstack/QEMU

Changed in horizon:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/187604

Changed in horizon:
assignee: nobody → Justin Pomeroy (jpomero)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/187604
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ea2f6b35da70d7a9d3f441553dac0f88f6ef9218
Submitter: Jenkins
Branch: master

commit ea2f6b35da70d7a9d3f441553dac0f88f6ef9218
Author: Justin Pomeroy <email address hidden>
Date: Tue Jun 2 09:21:42 2015 -0500

    Prevent multiple form submission on table row actions

    This disables any table row actions that do a form submit after an
    action is taken and the form is being submitted. It also changes the
    cursor to make it clear an action is taking place.

    Closes-Bug: #1433849
    Change-Id: I004f0ae43e5201eba30ff38a34be680416407fbc

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/188588

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/kilo)

Reviewed: https://review.openstack.org/189453
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=bafdabbb1ff3495e141699216d6ffae90e525ab8
Submitter: Jenkins
Branch: stable/kilo

commit bafdabbb1ff3495e141699216d6ffae90e525ab8
Author: Justin Pomeroy <email address hidden>
Date: Tue Jun 2 09:21:42 2015 -0500

    Prevent multiple form submission on table row actions

    This disables any table row actions that do a form submit after an
    action is taken and the form is being submitted. It also changes the
    cursor to make it clear an action is taking place.

    Closes-Bug: #1433849
    Change-Id: I004f0ae43e5201eba30ff38a34be680416407fbc
    (cherry picked from commit ea2f6b35da70d7a9d3f441553dac0f88f6ef9218)

    Handle modals properly when disabling table actions

    This fixes a problem when attempting to disable table actions on
    a modal dialog. It causes the Launch Instance modal to render
    incorrectly and other modals result in a
    "$form.on is not a function" error displayed in the browser
    console. This is because the modal init function is assuming the
    argument passed in is a jQuery reference to the modal but in
    reality it is just the modal DOM node itself. The problem is fixed
    by making a jQuery reference to the modal before preparing to
    disable the actions of any tables that might be displayed on it.

    Closes-Bug: #1462544
    Change-Id: I56399468ff5e2b5bcd0b285ece0d6dd001500c24
    (cherry picked from commit 54ee33c4d844961f7f7f7d94b3c298a015b09e95)

tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/kilo)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/188588
Reason: https://review.openstack.org/#/c/189453/ was merged.

Changed in horizon:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.