Fix is_hostname_safe for RFC compliance

Bug #1433832 reported by Michael Davies
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Michael Davies

Bug Description

In review https://review.openstack.org/#/c/165443 we added the ability to specify a FQDN for a node's logical name.

Unfortunately the implementation missed a couple of other changes that would allow a hostname to be used as the Node's logical name. Specifically:

1) Change to a maximum of 255 chars
2) Allowing each hostname or domain name in the FQDN to be up to 63 chars
3) Differentiating between hostname, and domain name (different regexs required)
4) Allowing _ in the domain names
5) Allowing . at the end of a FQDN

Also added tests for the above rules.

Michael Davies (mrda)
Changed in ironic:
assignee: nobody → Michael Davies (mrda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165666

Changed in ironic:
status: New → In Progress
aeva black (tenbrae)
Changed in ironic:
milestone: none → kilo-3
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-3 → kilo-rc1
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/165666
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=2d71701a279964f70210b05f6095c84d0de91c56
Submitter: Jenkins
Branch: master

commit 2d71701a279964f70210b05f6095c84d0de91c56
Author: Michael Davies <email address hidden>
Date: Wed Mar 18 17:37:26 2015 -0700

    Fix is_hostname_safe for RFC compliance

    In the move from Node name supporting just a hostname to now
    supporting a FQDN, we missed a few changes to keep this function
    being RFC compliant. This patch enhances the code and tests for
    this, and migrates the database to the longer name field format.

    Change-Id: Ib75c8b138d7165aedc74efead80d3fb755cab87b
    Closes-Bug: #1433832

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.