[Launch Instance Fix] Enhancing wizard widget

Bug #1433674 reported by Shaoquan Chen
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Shaoquan Chen

Bug Description

Add some events to Wizard widget to provide hooks for logic in model(s)
and controller(s) for each step.

New wizard events added are:
- ON_INIT_SUCCESS
- ON_INIT_ERROR
- ON_SWITCH
- BEFORE_SUBMIT
- AFTER_SUBMIT

Some features in Launch Instance work flow can take advantage of this
infrastructure change:
- Refreshing page on `AFTER_SUBMIT` event.
- Lazy data sync and validation on `BEFORE_SUBMIT` event.
- Dynamical showing/hiding optional steps/content according to async check for availability of certain services on `ON_INIT_SUCCESS` event.

Changed in horizon:
assignee: nobody → Shaoquan Chen (sean-chen2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165475

Changed in horizon:
status: New → In Progress
description: updated
tags: added: kilo-rc-potential
Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → Brian Tully (brian-tully)
Changed in horizon:
assignee: Brian Tully (brian-tully) → nobody
Changed in horizon:
assignee: nobody → Brian Tully (brian-tully)
Changed in horizon:
assignee: Brian Tully (brian-tully) → Travis Tripp (travis-tripp)
Changed in horizon:
assignee: Travis Tripp (travis-tripp) → Shaoquan Chen (sean-chen2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/165475
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=39ba4d19da95b5148ff3b0e963fee9ccf746d3a9
Submitter: Jenkins
Branch: master

commit 39ba4d19da95b5148ff3b0e963fee9ccf746d3a9
Author: Shaoquan Chen <email address hidden>
Date: Wed Mar 18 08:49:24 2015 -0700

    [Launch Instance Fix] Enhancing wizard widget

    1) Add some events to Wizard widget to provide hooks for logic in model(s)
    and controller(s) for each step.

    New wizard events added are:
    - ON_INIT_SUCCESS
    - ON_INIT_ERROR
    - ON_SWITCH
    - BEFORE_SUBMIT
    - AFTER_SUBMIT

    Some features in Launch Instance work flow can take advantage of this
    infrastructure change:

    - Refreshing page on `AFTER_SUBMIT` event.
    - Lazy data sync and validation on `BEFORE_SUBMIT` event.
    - Dynamical showing/hiding optional steps/content according to async check for
      availability of certain services on `ON_INIT_SUCCESS` event.

    2) Add a new feature to check readiness for each step that provides a optional `checkReadiness`
    method. Each such a method should return a promise. When this method is
    provided with the step, the `ready` property of the step will be set to
    `false` until the promise gets resolved. If no `checkReadiness` method
    provided, the `ready` property of the step will be set to `true` directly.

    This it useful for those work flow where some step may be optional and
    should be showing to UI conditionally and the check for the condition
    is an asynchronous operation.

    Co-Authored-By: Brian Tully <email address hidden>
    Closes-Bug: 1433674
    Change-Id: I556e263f4c701a378452b4397585f1b4d8abb763

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-rc1
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.