Floating IP Reverse DNS API does not respect async operations

Bug #1433645 reported by Graham Hayes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Endre Karlson

Bug Description

eg:
 (.venv)➜ designate git:(master) ✗ http PATCH 127.0.0.1:9001/v2/reverse/floatingips/RegionOne:a45f06f6-3611-472b-ba88-5f6c89a95e49 X-Auth-Project-ID:5df86946c67c48bd9eef60f17ea07b96 floatingip:='{}'
  HTTP/1.1 200 OK
  Content-Length: 4
  Content-Type: application/json; charset=UTF-8
  Date: Wed, 18 Mar 2015 14:42:31 GMT
  X-Openstack-Request-Id: req-eac773bf-9ecd-40ad-9004-f05c7efd7308

null

FIP PTRDNAME should have been deleted.

  (.venv)➜ designate git:(master) ✗ http 127.0.0.1:9001/v2/reverse/floatingips X-Auth-Project-ID:5df86946c67c48bd9eef60f17ea07b96 (adapters-take-3⚡)
  HTTP/1.1 200 OK
  Content-Length: 360
  Content-Type: application/json; charset=UTF-8
  Date: Wed, 18 Mar 2015 14:42:43 GMT
  X-Openstack-Request-Id: req-34095043-2fda-4a5b-8157-a4f1691a0c2b

  {
      "floatingips": [
          {
              "address": "10.2.6.236",
              "description": null,
              "id": "RegionOne:a45f06f6-3611-472b-ba88-5f6c89a95e49",
              "links": {
                  "self": "http://127.0.0.1:9001/v2/reverse/floatingips/RegionOne:a45f06f6-3611-472b-ba88-5f6c89a95e49"
              },
              "ptrdname": "www.test.com.",
              "ttl": 3600
          }
      ],
      "links": {
          "self": "http://127.0.0.1:9001/v2/reverse/floatingips"
      },
      "metadata": {}
  }

It seems that record is in PENDING state - and the FIP code does not filter it out

  {
              "action": "DELETE",
              "created_at": "2015-03-18T14:41:32.000000",
              "description": null,
              "id": "4b6bfee8-2d02-47a7-9cda-4d680b2a265e",
              "links": {
                  "self": "http://127.0.0.1:9001/v2/zones/bbdaa5a4-797f-401d-8a20-941a47fe102c/recordsets/4b6bfee8-2d02-47a7-9cda-4d680b2a265e"
              },
              "name": "236.6.2.10.in-addr.arpa.",
              "records": [
                  "www.test.com."
              ],
              "status": "PENDING",
              "ttl": null,
              "type": "PTR",
              "updated_at": null,
              "version": 1,
              "zone_id": "bbdaa5a4-797f-401d-8a20-941a47fe102c"
          },

Tim Simmons (timsim)
Changed in designate:
milestone: none → kilo-rc1
importance: Undecided → Critical
status: New → Triaged
Changed in designate:
assignee: nobody → Endre Karlson (endre-karlson)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/168357

Changed in designate:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/168357
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=8f06223e717e7063ead89f192b137465621ddd6c
Submitter: Jenkins
Branch: master

commit 8f06223e717e7063ead89f192b137465621ddd6c
Author: Endre Karlson <email address hidden>
Date: Fri Mar 27 15:07:30 2015 +0100

    Sync up FIP behaviour to match latest PoolManager

    * Add action and status fields from Record or None if no Record for the FIP.
    * Change status code to 202 for async ops.

    Closes-Bug: #1433645

    Change-Id: I8ee44f1a760bcd23c03acae8e722bb5db5017b93

Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.