novaclient record request time even when timing is set to False

Bug #1433491 reported by ZhiQiang Fan
24
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Medium
ZhiQiang Fan

Bug Description

The expected behavior is when timing is True, then we record each request's time, then we should call reset_timings() to clear memory

However, the v1_1.client record each request's time no matter what timing is set, then after long running time in service like ceilometer-agent-compute, the memory keeps increasing

We'd better not record request's time when timing is set to False

ZhiQiang Fan (aji-zqfan)
Changed in python-novaclient:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165343

Changed in python-novaclient:
status: New → In Progress
melanie witt (melwitt)
Changed in python-novaclient:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/165343
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=1c39f8fabf8ed44e0de563893d5813be1bf7b5e3
Submitter: Jenkins
Branch: master

commit 1c39f8fabf8ed44e0de563893d5813be1bf7b5e3
Author: ZhiQiang Fan <email address hidden>
Date: Wed Mar 18 17:37:54 2015 +0800

    Don't record time when self.timing is False

    The expected behavior is when timing is True, then we record each
    request's time, then we should call reset_timings() to release memory.

    However, the shell, client.{HTTPClient,SessionClient} will record each
    request's time no matter what timing is set, then after long running
    time in service like ceilometer-agent-compute, the memory keeps increasing.

    We'd better not record request's time when timing is set to False.
    Users are not responiable to call reset_timings() when they don't want
    timing functionality.

    Change-Id: I3e7d2fadf9a21be018781d528a1b6562228da6dd
    Closes-Bug: #1433491

Changed in python-novaclient:
status: In Progress → Fix Committed
Sean Dague (sdague)
Changed in python-novaclient:
milestone: none → 2.24.1
Sean Dague (sdague)
Changed in python-novaclient:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/199569

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-novaclient (stable/kilo)

Change abandoned by Tony Breeds (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/199569
Reason: This review is being abandoned as the stable/kilo will go End-Of-Life (EOL) in the near future.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.