disable_offload from interface_properties don't applied to bond chields

Bug #1433462 reported by Sergey Vasilenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Sergey Vasilenko
Tags: l23network
Changed in fuel:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Stanislav Makar (smakar) wrote :

It seems that the function (def self.correct_ethtool_set(prop_hash)) condition
if (!prop_hash.has_key?('ethtool') or prop_hash['ethtool'].empty?) \
 and (prop_hash.has_key?('vendor_specific') and prop_hash['vendor_specific']['disable_offloading'])

https://review.openstack.org/#/c/164450/8/deployment/puppet/l23network/lib/puppet/parser/functions/generate_network_config.rb

doesn't count that disable_offloading for bond is in prop_hash['interface_properties']['vendor_specific']['disable_offloading']

Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
assignee: Sergey Vasilenko (xenolog) → Dmitry Ilyin (idv1985)
Changed in fuel:
assignee: Dmitry Ilyin (idv1985) → Sergey Vasilenko (xenolog)
Changed in fuel:
assignee: Sergey Vasilenko (xenolog) → Vladimir Kuklin (vkuklin)
Changed in fuel:
assignee: Vladimir Kuklin (vkuklin) → Sergey Vasilenko (xenolog)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/165348
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=b276fdeca06cadc6477f5d61de3d37b572e8169e
Submitter: Jenkins
Branch: master

commit b276fdeca06cadc6477f5d61de3d37b572e8169e
Author: Sergey Vasilenko <email address hidden>
Date: Thu Mar 19 20:23:07 2015 +0300

    FIX: disable_offload from interface_properties isn't applied to bonded physical interfaces

    This fix contains two sub-fixes:
    * old code contains wrong logical condition.
      In some cases was called .empty? method for non-hash or nil objects
    * while parsing transformations for bonds, 'disable-offloading' flag
      should be passed to bond-members transparently.

    Closes-bug: #1433462
    Change-Id: I63920e964a2ef4d3eb26c7a6175d2a676b426de0

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Stanislav Makar (smakar) wrote :

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.1"
  openstack_version: "2014.2.2-6.1"
  api: "1.0"
  build_number: "472"
  build_id: "2015-05-26_23-21-01"
  nailgun_sha: "f737675091bd1903aace0e36812e855ce47dfec7"
  python-fuelclient_sha: "e19f1b65792f84c4a18b5a9473f85ef3ba172fce"
  astute_sha: "0bd72c72369e743376864e8e8dabfe873d40450a"
  fuel-library_sha: "8cfeca1a86179ebed1e4e03b2133b49c27350f6f"
  fuel-ostf_sha: "87819878bc0ca572900e1f6933d9b99e666d6f62"
  fuelmain_sha: "13b3e9cf074ba1cf1ae06509c55fbab613c73f4e"

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.