[Launch Instance Fix] Enabling loading script from file

Bug #1433438 reported by Shaoquan Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Shaoquan Chen

Bug Description

In configuration step of Launch Instance work flow, we should allow for uploading script from local file. HTML5 provide a File API which makes it possible

 - Browser support: IE10+, Chrome, FireFox and Safari on Mac.
 - The max length of script allowed it 16K.
 - Validation is still missing.

https://review.openstack.org/#/c/165300/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/165300

Changed in horizon:
assignee: nobody → Shaoquan Chen (sean-chen2)
status: New → In Progress
description: updated
Changed in horizon:
milestone: none → kilo-rc1
Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → Brian Tully (brian-tully)
Changed in horizon:
assignee: Brian Tully (brian-tully) → Shaoquan Chen (sean-chen2)
Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → Brian Tully (brian-tully)
Changed in horizon:
assignee: Brian Tully (brian-tully) → Shaoquan Chen (sean-chen2)
Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → Brian Tully (brian-tully)
Changed in horizon:
assignee: Brian Tully (brian-tully) → Shaoquan Chen (sean-chen2)
Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → Brian Tully (brian-tully)
Changed in horizon:
assignee: Brian Tully (brian-tully) → Travis Tripp (travis-tripp)
Changed in horizon:
assignee: Travis Tripp (travis-tripp) → Shaoquan Chen (sean-chen2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/165300
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5bec804f2a40299a9de4694b4b79e65f678a3aa7
Submitter: Jenkins
Branch: master

commit 5bec804f2a40299a9de4694b4b79e65f678a3aa7
Author: Brian Tully <email address hidden>
Date: Wed Apr 1 20:41:29 2015 -0400

    [Launch Instance Fix] Enabling loading script from local file

    In configuration step of Launch Instance work flow, we should allow for
    uploading script from local file. HTML5 provides a File API which makes
    it possible.

     - Browser support: IE10+, Chrome, FireFox and Safari (on Mac).
     - Max length of script is 16K.
     - Validation is added.

    Co-Authored-By: Brian Tully <email address hidden>
    Closes-Bug: 1433438
    Change-Id: I967b4f3e3dbecfc9a95988fdbaa603a731db0a7f

Changed in horizon:
status: In Progress → Fix Committed
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.