[Launch Instance Fix] source step - fix donut chart dynamic update - limit instance count

[Brian Tully]

In the current version of the Launch Instance Wizard Source Step, the instance count field is not correctly limited based on current instance usage and nova limits (maxTotalInstances). There is a bug whereby the user can enter an instance count of more than what is available, and in addition the donut chart does not update properly when this occurs. We should correct this so that if a user enters a number greater than what is available, it should automatically round down to the available count.

Example. If I have 10 max instances quota, and currently have 6 instances in use, I should only be able to specify 4 as my instance count (which will update the donut chart to 100%). However there is nothing in the code that limits me from entering a higher number. We should add some code that limits the instance count based on # remaining, and automatically rounds down to the highest number of instances that would prevent the user from going over 100%

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/164912

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/164912
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=02acf125597ef48c5e07d80e5f59d189c6fee6ec
Submitter: Jenkins
Branch: master

commit 02acf125597ef48c5e07d80e5f59d189c6fee6ec
Author: Brian Tully <email address hidden>
Date: Mon Mar 16 21:02:41 2015 -0400

    Source step - fix instance count limit and donut chart

    In the current version of the Launch Instance Wizard Source Step,
    the instance count field is not correctly limited based on current
    instance usage and nova limits (maxTotalInstances). There is a bug
    whereby the user can enter an instance count of more than what is
    available (exceeding their quota). In addition, the donut chart
    does not update properly when this occurs. This patch corrects this
    so that if a user enters a number greater than what is available,
    it automatically changes the count to the maximum count that will still
    stay within quota limits.

    Closes-Bug: 1432897

    Change-Id: I24f1309b04f3c045c02b67409c49fc3ee86aea3f