ethtool -t ethX failing with Ubuntu 15.04 (3.19.0-8-generic) (Mellanox)

[bugproxy]

SRU Justification:

Impact: Ethtool selftest does not work for Mellanox CX3 / CX3 Pro
Fix: Upstream development, already tested and proved to work.
Testcase:
    Execute "ethtool -t <mellanox_cx3_interface>" and see result FAIL
    Use provided PPA for testing the patch (Received good feedback)

Obs: Affects only 3.19+ kernels (fixes commit dd65bea)

----

Original Bug Description:

== Comment: #0 - Carol L. Soto <email address hidden> - 2015-03-16 15:54:40 ==
---Problem Description---
ethtool -t eth18
The test result is FAIL
The test extra info:
Interrupt Test 0
Link Test 0
Speed Test 0
Register Test 0
Loopback Test 1

Will see this message in dmesg:
mlx4_en: eth18: Loopback packet didn't arrive

Contact Information = Carol <email address hidden>

---uname output---
Linux powerio-le21 3.19.0-8-generic #8-Ubuntu SMP Tue Mar 10 13:07:58 UTC 2015 ppc64le ppc64le ppc64le GNU/Linux

---Additional Hardware Info---
Need a Mellanox RoCE adapter like CX3 40G or CX3 Pro 10G

Machine Type = P8

---Debugger---
A debugger is not configured

---Steps to Reproduce---
 ethtool -t ethX

Stack trace output:
 no

Oops output:
 no

System Dump Info:
  The system is not configured to capture a system dump.

*Additional Instructions for Carol <email address hidden>:
-Attach sysctl -a output output to the bug.

== Comment: #1 - Carol L. Soto <email address hidden> - 2015-03-16 15:55:36 ==
Patch to fix this issue is available in upstream:

From 1037ebbbd262227a91dfdd558159e345d4edf6b7 Mon Sep 17 00:00:00 2001
From: Ido Shamay <email address hidden>
Date: Mon, 2 Mar 2015 18:22:16 +0200
Subject: net/mlx4_en: Disbale GRO for incoming loopback/selftest packets

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/drivers/net/ethernet/mellanox/mlx4?id=1037ebbbd262227a91dfdd558159e345d4edf6b7

[Dave Heller (hellerda)]

Hi Ubuntu, the request is to pick up the aforementioned patch. Let us know if more info req'd. Thanks.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2015-06-02 14:50 EDT-------
Hi Canonical, any update? I see this is still unassigned.

[Brian Fromme (brianfromme)]

Hi Dave,

Thanks for letting us know about this patch. I have forwarded the information to our engineering team.

[Rafael David Tinoco (rafaeldtinoco)]

I have made available the following PPA:

https://launchpad.net/~inaddy/+archive/ubuntu/lp1432848

available for testing. Please provide feedback if kernel:

3.19.0-22.22hf00084654v20150624b1

fixes the issue.

INSTRUCTIONS:

# apt-get update && apt-get dist-upgrade
# add-apt-repository ppa:inaddy/lp1432848
# apt-get update
# apt-get install linux-image-3.19.0-22-generic linux-headers-3.19.0-22-generic linux-image-extra-3.19.0-22-generic

Thank you

Rafael Tinoco

[Kamal Heib (kamalh-s)]

Hello Rafael,

The PPA that you provided fixes this issue.

Thanks,
Kamal

root@reg-l-vrt-036-007:~# ethtool -t eth1
The test result is PASS
The test extra info:
Interrupt Test 0
Link Test 0
Speed Test 0
Register Test 0
Loopback Test 0

root@reg-l-vrt-036-007:~# uname -r
3.19.0-22-generic

[Rafael David Tinoco (rafaeldtinoco)]

I just submitted the SRU proposal for the kernel team mailing list. This bug is waiting for approval and merge.

Thank you

Rafael Tinoco

[Brad Figg (brad-figg)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-vivid' to 'verification-done-vivid'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2015-07-09 19:14 EDT-------
This is working
uname -a
Linux powerio-le13 3.19.0-15-generic #15-Ubuntu SMP Thu Apr 16 23:32:13 UTC 2015 ppc64le ppc64le ppc64le GNU/Linux
root@powerio-le13:~# lspci -v | grep Mella
00:05.0 Ethernet controller: Mellanox Technologies MT27500 Family [ConnectX-3]
root@powerio-le13:~# ethtool -t eth1
The test result is PASS
The test extra info:
Interrupt Test 0
Link Test 0
Speed Test 0
Register Test 0
Loopback Test 0

[Gavin Guo (mimi0213kimo)]

Hi Clsoto,

Tinoco is on vacation now, I'm his proxy. And I saw you have tested the kernel to verify the ethtool. Really thanks for your effort to do that. Except on thing that I saw the kernel version

Linux powerio-le13 3.19.0-15-generic #15-Ubuntu SMP Thu Apr 16 23:32:13 UTC 2015 ppc64le ppc64le ppc64le GNU/Linux

is not the proposed kernel. Could you help to test the newest proposed kernel to see if it fixes the bug?

### STEPS ###
Add the following line to the /etc/apt/sources.list:
deb http://archive.ubuntu.com/ubuntu/ vivid-proposed restricted main multiverse universe

$ sudo apt-get update
$ sudo apt-get install -y linux-image-3.19.0-23-generic linux-image-extra-3.19.0-23-generic linux-headers-3.19.0-23 linux-headers-3.19.0-23-generic

Thanks for your help.

[Kamal Heib (kamalh-s)]

Hello Gavin,

I tested the kernel and it is fixing this issue.

uname -a
Linux reg-l-vrt-036-007 3.19.0-23-generic #24-Ubuntu SMP Tue Jul 7 18:52:55 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

# ethtool -t eth1
The test result is PASS
The test extra info:
Interrupt Test 0
Link Test 0
Speed Test 0
Register Test 0
Loopback Test 0

# lspci -d 15b3:
00:05.0 Network controller: Mellanox Technologies MT27500 Family [ConnectX-3]

# ethtool -i eth1
driver: mlx4_en
version: 2.2-1 (Feb 2014)
firmware-version: 2.34.5000
bus-info: 0000:00:05.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: no
supports-register-dump: no
supports-priv-flags: yes

Thanks,
Kamal

[Gavin Guo (mimi0213kimo)]

@Kamal,

Thanks for your verification. I'll modify the tag verification-needed-vivid to verification-done-vivid.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 3.19.0-23.24

---------------
linux (3.19.0-23.24) vivid; urgency=low

  [ Luis Henriques ]

  * Release Tracking Bug
    - LP: #1472346

  [ Chris J Arges ]

  * SAUCE: Don't use atomic read in evlist.c
    - LP: #1410673

linux (3.19.0-23.23) vivid; urgency=low

  [ Brad Figg ]

  * Release Tracking Bug
    - LP: #1472048

  [ Chris J Arges ]

  * [Config] Add CRYPTO_DEV_NX_*, 842_* as modules
    - LP: #1454687

  [ Lu, Han ]

  * SAUCE: i915_bpo: drm/i915/audio: add codec wakeup override
    enabled/disable callback
    - LP: #1460674

  [ Timo Aaltonen ]

  * SAUCE: Backport I915_OVERLAY_DISABLE_DEST_COLORKEY
    - LP: #1460674
  * SAUCE: i915_bpo: Rebase to drm-intel-next-fixes-2015-05-29
    - LP: #1460674
  * SAUCE: i915_bpo: Revert "drm/i915: Implement the intel_dp_autotest_edid
    function for DP EDID complaince tests"
    - LP: #1460674
  * SAUCE: i915_bpo: Revert "drm/i915: Add debugfs test control files for
    Displayport compliance testing"
    - LP: #1460674
  * SAUCE: Load i915_bpo from the hda driver on SKL/CHV
    - LP: #1460674
  * SAUCE: i915_bpo: Don't try to support BXT
    - LP: #1460674
  * SAUCE: i915_bpo: drm/i915/skl: Fix DMC API version.

  [ Upstream Kernel Changes ]

  * Revert "usb: dwc2: add bus suspend/resume for dwc2"
    - LP: #1471252
  * Revert "HID: logitech-hidpp: support combo keyboard touchpad TK820"
    - LP: #1471252
  * Revert "KVM: x86: drop fpu_activate hook"
    - LP: #1471252
  * Revert "libceph: clear r_req_lru_item in __unregister_linger_request()"
    - LP: #1471252
  * drm/i915: add component support
    - LP: #1460661
  * ALSA: hda: export struct hda_intel
    - LP: #1460661
  * ALSA: hda: pass intel_hda to all i915 interface functions
    - LP: #1460661
  * ALSA: hda: add component support
    - LP: #1460661
  * drm/atomic-helpers: Fix documentation typos and wrong copy&paste
    - LP: #1460674
  * drm/atomic: Rename drm_atomic_helper_commit_pre_planes() state argument
    - LP: #1460674
  * drm/atomic-helper: Rename commmit_post/pre_planes
    - LP: #1460674
  * drm/atomic-helpers: make mode_set hooks optional
    - LP: #1460674
  * drm/atomic-helper: Fix kerneldoc for prepare_planes
    - LP: #1460674
  * drm: Complete moving rotation property to core
    - LP: #1460674
  * drm: Share plane pixel format check code between legacy and atomic
    - LP: #1460674
  * drm/atomic: Constify a bunch of functions pointer structs
    - LP: #1460674
  * drm: Fix some typo mistake of the annotations
    - LP: #1460674
  * drm: change connector to tmp_connector
    - LP: #1460674
  * drm: atomic: Expose CRTC active property
    - LP: #1460674
  * drm: atomic: Allow setting CRTC active property
    - LP: #1460674
  * drm/atomic-helpers: Properly avoid full modeset dance
    - LP: #1460674
  * drm/atomic: Add helpers for state-subclassing drivers
    - LP: #1460674
  * drm: Fix some typos
    - LP: #1460674
  * drm/atomic: Add for_each_{connector,crtc,plane}_in_state helper macros
    - LP: #1460674
  * drm/atomic-helper: Don't call atomic_update_plane when it stays off
    - LP: #1460674
  * drm/atomic-helper: Really recover pre-atomic plane/cursor behavior
 ...