[nailgun] Introduce the settings.yaml validation

[Anastasia Palkina]

"build_id": "2015-03-15_22-54-44",
"ostf_sha": "e86c961ceacfa5a8398b6cbda7b70a5f06afb476",
"build_number": "200",
"release_versions": {"2014.2-6.1": {"VERSION": {"build_id": "2015-03-15_22-54-44", "ostf_sha": "e86c961ceacfa5a8398b6cbda7b70a5f06afb476", "build_number": "200", "api": "1.0", "nailgun_sha": "713e6684f9f54e29acfe6b8ebf641b9de2292628", "production": "docker", "python-fuelclient_sha": "cc64fff91fb0d78e5a02e7b93ceff224296f84fb", "astute_sha": "93e427ac49109fa3fd8b0e1d0bb3d14092be2e8c", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "c97fd8a789645bda48d06da224f994f8b52d82f5", "fuellib_sha": "553cb0cffa40a5f57313f962b6ec6a9bd89306ba"}}},
"auth_required": true,
"api": "1.0",
"nailgun_sha": "713e6684f9f54e29acfe6b8ebf641b9de2292628",
"production": "docker",
"python-fuelclient_sha": "cc64fff91fb0d78e5a02e7b93ceff224296f84fb",
"astute_sha": "93e427ac49109fa3fd8b0e1d0bb3d14092be2e8c",
"feature_groups": ["mirantis"],
"release": "6.1",
"fuelmain_sha": "c97fd8a789645bda48d06da224f994f8b52d82f5",
"fuellib_sha": "553cb0cffa40a5f57313f962b6ec6a9bd89306ba"

1. Install ISO
2. Remove feature_group 'mirantis' from /etc/fuel/version.yaml on master node
http://paste.openstack.org/show/192591/
3. Restart nailgun container
4. Open Web UI
5. Click to page Releases. Nothing happened. There is error in Firebug console: argument of type 'NoneType' is not iterable (see screen)
Also I cannot create new cluster because 'Release' field is empty (see screen)

[Aleksey Kasatkin (alekseyk-ru)]

It is resulted in wrong format for 'feature_groups'. It should be a list. Do we need to check 'feature_groups' for proper value type? Opinions?

[Aleksey Kasatkin (alekseyk-ru)]

So, you removed a list, not just 'mirantis' feature group.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/165488

[Ihor Kalnytskyi (ikalnytskyi)]

I believe that the issue is invalid. The feature_groups has to be a list, either empty or not. We shouldn't perform checks in many places around the code.

[Alexander Kislitsky (akislitsky)]

I propose to change subject of the bug. We should introduce validation of settings.yaml.
But this it is not High level and not for 6.1.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alexander Kislitsky (<email address hidden>) on branch: master
Review: https://review.openstack.org/165488
Reason: Requires feature implementation instead fast-fix.

[Alexander Kislitsky (akislitsky)]

Sorry, forgot about snapshot.
Attached now.

[Alexander Kislitsky (akislitsky)]

Wrong comment

[Vladimir Sharshov (vsharshov)]

This is feature. It is need blueprint to implementation.

[Vladimir Sharshov (vsharshov)]

Moving to 8.0

[Alexander Kislitsky (akislitsky)]

We passed SCF in 8.0. Moving the bug to 9.0.