Services-show on empty environment failed

Bug #1432568 reported by Ekaterina Chernova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-muranoclient
Fix Released
Medium
Ekaterina Chernova

Bug Description

Empty body of the *response* has to be also handled:

* $ murano environment-create dummy
+----------------------------------+-------+---------------------+---------------------+
| ID | Name | Created | Updated |
+----------------------------------+-------+---------------------+---------------------+
| db98819a639b4235b401763c3f8c3d81 | dummy | 2015-02-25T09:21:38 | 2015-02-25T09:21:38 |
+----------------------------------+-------+---------------------+---------------------+

* $ murano service-show db98819a639b4235b401763c3f8c3d81 /
'list' object has no attribute 'items'

The reason is that muranoclient/common/http.py json_request(..) return None on the empty list of env's services.

Changed in python-muranoclient:
milestone: none → 0.5.6
Changed in murano:
status: New → Confirmed
assignee: nobody → Ekaterina Chernova (efedorova)
milestone: none → kilo-3
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/164750

Changed in murano:
status: Confirmed → In Progress
Changed in murano:
assignee: Ekaterina Chernova (efedorova) → Kirill Zaitsev (kzaitsev)
Changed in murano:
assignee: Kirill Zaitsev (kzaitsev) → Ekaterina Chernova (efedorova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/164750
Committed: https://git.openstack.org/cgit/stackforge/python-muranoclient/commit/?id=b6e43ca7b615927a0eec4f8a45b4687e27efd073
Submitter: Jenkins
Branch: master

commit b6e43ca7b615927a0eec4f8a45b4687e27efd073
Author: Ekaterina Chernova <email address hidden>
Date: Mon Mar 16 18:48:44 2015 +0300

    Fix service-show command

    In case no services are exist, command failed to execute.
    Now, path parameter is optional and whithout it
    all services in the environment are shown.

    Change-Id: I81112315fce1937d94bc0772e1b695c2d815c639
    Closes-Bug: #1432568

Changed in murano:
status: In Progress → Fix Committed
no longer affects: murano
Revision history for this message
Ekaterina Chernova (efedorova) wrote :
Changed in python-muranoclient:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Ekaterina Chernova (efedorova)
Changed in python-muranoclient:
status: Fix Committed → Fix Released
tags: added: juno-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.