Neutron: port-create missing help info for the option: --binding

[Danny Choi]

nova-manage version: 2015.1

Issue: Neutron port-create missing help info for the option: --binding:vnic-type
Valid inputs are 'normal', 'direct' and 'macvtap'.

ubuntu@trusty1:~/devstack$ neutron port-create --name sriov-mactap --binding:vnic-type=mactap private
Invalid input for binding:vnic_type. Reason: 'mactap' is not in ['normal', 'direct', 'macvtap'].

ubuntu@trusty1:~/devstack$ neutron help port-create
usage: neutron port-create [-h] [-f {html,json,shell,table,value,yaml}]
                           [-c COLUMN] [--max-width <integer>]
                           [--prefix PREFIX] [--request-format {json,xml}]
                           [--tenant-id TENANT_ID] [--name NAME]
                           [--admin-state-down] [--mac-address MAC_ADDRESS]
                           [--device-id DEVICE_ID]
                           [--fixed-ip subnet_id=SUBNET,ip_address=IP_ADDR]
                           [--security-group SECURITY_GROUP | --no-security-groups]
                           [--extra-dhcp-opt EXTRA_DHCP_OPTS]
                           NETWORK

[Vikram Hosakote (vhosakot)]

Reproduced successfully with the latest python-neutronclient (2.3.11).

$ neutron port-create --name sriov-mactap --binding:vnic-type=mactap private
Invalid input for binding:vnic_type. Reason: 'mactap' is not in ['normal', 'direct', 'macvtap'].

$ neutron --version
2.3.11

The following three commands work fine.

neutron port-create --name sriov-mactap --binding:vnic-type=normal private
neutron port-create --name sriov-mactap --binding:vnic-type=direct private
neutron port-create --name sriov-mactap --binding:vnic-type=macvtap private

port-create's help text must be fixed to print info for --binding:vnic-type. Fixing it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169443

[Vikram Hosakote (vhosakot)]

Fix proposed - https://review.openstack.org/169443

Unit-test results:
==============

$ neutron port-create --help | grep -i vnic
                           [--binding:vnic-type <direct | macvtap | normal>]
  --binding:vnic-type <direct | macvtap | normal>
                        VNIC type for this port.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169443
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=052b9da6fae964c3719b65f74baa89ab8b4344f4
Submitter: Jenkins
Branch: master

commit 052b9da6fae964c3719b65f74baa89ab8b4344f4
Author: Vikram Hosakote <email address hidden>
Date: Tue Mar 31 10:02:27 2015 -0700

    'neutron port-create' missing help info for --binding:vnic-type

    --binding:vnic-type can be specified for 'neutron port-create'
    to create SR-IOV vNIC ports, but the help info is missing for
    --binding:vnic-type.

    This patch fixes the above bug. Below is the output.

    $ neutron port-create --help | grep -i vnic
                  [--vnic-type <direct | macvtap | normal>]
      --vnic-type <direct | macvtap | normal>
                            VNIC type for this port.

    DocImpact

    Change-Id: Ib31c345d84df8861a058fdd221bb7bc9fc33b6c9
    Closes-bug: #1432393