OS::Ceilometer::GnocchiMetricslarm is a typo

Bug #1431873 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Miguel Grinberg

Bug Description

We've merged a resource with a typo in the type name.

https://github.com/openstack/heat/blob/master/contrib/heat_gnocchi/heat_gnocchi/resources/gnocchi_alarm.py#L131

Obviously fixing this will be a backwards incompatible change, unless we just persist the typo for historical reasons and add another type alias with the correct "Alarm" suffix.

Steven Hardy (shardy)
summary: - OS::Ceilometer::GnocchiMetricslarm is a typo :(
+ OS::Ceilometer::GnocchiMetricslarm is a typo
Revision history for this message
Miguel Grinberg (miguelgrinberg) wrote :

Given that (a) this is a contrib plugin, (b) it is introduced in the Kilo cycle and (c) it's been out for a little over one month, I think it is safe to rename and not keep the typo version in the code.

Changed in heat:
assignee: nobody → Miguel Grinberg (miguelgrinberg)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/164297

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/164297
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=68041ebc8b7ca647bbad35545d9dab799e50b5b5
Submitter: Jenkins
Branch: master

commit 68041ebc8b7ca647bbad35545d9dab799e50b5b5
Author: Miguel Grinberg <email address hidden>
Date: Fri Mar 13 18:24:09 2015 +0000

    Fix typo in contrib resource declaration

    Change-Id: Id061de58eb9b446e7cc14804f70b647f1b49e6b1
    Closes-Bug: #1431873

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to heat (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/164595

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to heat (master)

Reviewed: https://review.openstack.org/164595
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=bde1dbcf934d6a7a47c359b986a5a67611c79748
Submitter: Jenkins
Branch: master

commit bde1dbcf934d6a7a47c359b986a5a67611c79748
Author: Sergey Kraynev <email address hidden>
Date: Mon Mar 16 03:55:27 2015 -0400

    Source gnocchi alarms resources in the right way

    Previously we missed typo in resource mapping name. It happend due to
    using hardcoded name in registring new resource in environment.
    Other resources in contrib use alternative approach, i.e. they register
    classes using mapping function from native module.

    This patch adds same approach for Gnocchi alarms. Also small refactoring
    for re-using existing code in test.

    Change-Id: Ibe8dfc54f9502fb6e97e496fb51b4e46e7f4d8a9
    Related-Bug: #1431873

Thierry Carrez (ttx)
Changed in heat:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.