extra semicolon in _variables.scss breaks some css

Bug #1431428 reported by Brian Tully
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Brian Tully

Bug Description

There is an extra semicolon in _variables.scss that will output a stray "!default;" at the top of the compiled CSS files, which usually will invalidate the first CSS statement in the file (as well as invalidate the css).

The line is:

$helpPanelBorderColor: #888; !default;

Note there should not be a semicolon before the "!default;"

Tags: css horizon scss
Changed in horizon:
assignee: nobody → Brian Tully (brian-tully)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/163885

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/163885
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5d2b7a7fc7d9292865edcbb2fe184d35f4b8d41a
Submitter: Jenkins
Branch: master

commit 5d2b7a7fc7d9292865edcbb2fe184d35f4b8d41a
Author: Brian Tully <email address hidden>
Date: Thu Mar 12 11:59:54 2015 -0400

    Fix CSS, remove bad semicolon in _variables.scss

    There is an extra semicolon in _variables.scss that will output a
    stray "!default;" at the top of the compiled CSS files, which usually
    will invalidate the first CSS statement in the file (as well as
    invalidate the css).

    Change-Id: I247f330225cf14c071e8aeb6bcd8321d5030ca72
    Closes-Bug: 1431428

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.