New field 'name' not supported in port REST API

Bug #1431204 reported by Michael Davies
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Michael Davies

Bug Description

We've recently added support for logical names in Ironic (see https://review.openstack.org/#/c/141737/), with most of the change focused around the 'Node' portion of the REST API.

However in the 'Port' section of the REST API it's possible to select ports based upon a node. Right now it's only possible to select the node using node_uuid. We really should add support for selecting the node via the node's name.

Affect APIs:
  GET /v1/ports
  GET /v1/ports/detail

Michael Davies (mrda)
Changed in ironic:
status: New → In Progress
assignee: nobody → Michael Davies (mrda)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/163730

Revision history for this message
Ruby Loo (rloo) wrote :

Michael, when a port is created, it currently wants a node uuid. What about allowing a node name instead?

aeva black (tenbrae)
Changed in ironic:
importance: Undecided → Medium
milestone: none → kilo-rc1
aeva black (tenbrae)
Changed in ironic:
milestone: kilo-rc1 → kilo-3
Revision history for this message
aeva black (tenbrae) wrote :

After testing the proposed patch and finding a significant problem (it breaks backwards compat for querying ports) I am bumping this to liberty.

Changed in ironic:
milestone: kilo-3 → liberty-1
Changed in ironic:
milestone: liberty-1 → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/163730
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=1aff17ff0f554b1892eeb0c6b24eefaee045dc05
Submitter: Jenkins
Branch: master

commit 1aff17ff0f554b1892eeb0c6b24eefaee045dc05
Author: Michael Davies <email address hidden>
Date: Thu Mar 12 18:46:33 2015 +1030

    New field 'name' not supported in port REST API

    Add support for referring to nodes by their logical name in the
    port section of the REST API.

    As part of this, refactored some code out of node.py into
    utils.py, along with moving the corresponding tests.

    Change-Id: I5dd61582e6e009f44dd3eed2ce014d0000c94b19
    Closes-Bug: #1431204

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.