vmware: snapshot not passing image properties

[Marcelo]

Tried on ice-house.

Uploaded an vmdk image to glance passing the parameter vmware_disktype=thin. I know that it's still not implemented the automatic conversion from thick to thin, so after the upload I went in the ESX, accessed glance folder in the datastore, and converted the image manually to a thin disk (vmkfstools -i...).

Then when I launch an instance the disk is thin, so the image is ok.

But when I take a snapshot, the image created seems to ignore the previous properties, creating an image with vmware_disktype=preallocated, occupying a lot more of space in the data store.

[Radoslav Gerganov (rgerganov)]

In Kilo we create the snapshots in streamOptimized format, please see:

https://github.com/openstack/nova/commit/806bdaf94794532132a933c170520629da4ceb0e

Unfortunately, I don't think we will backport this behavior to Icehouse.

[Sean Dague (sdague)]

so this is fixed in master? (marking as Fix Released accordingly, please change back to New if that's not the case).