cells rpc API _handle_cell_delete regressed with commit 222d44532c65ddf3f26532ced217890628352536

Bug #1430822 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Critical
Dan Smith

Bug Description

https://review.openstack.org/#/c/121800/ changes the cells RPC API in a non-backwards compatible way in the _handle_cell_delete method where method_name should be 'soft' or 'hard' but it's changed to 'soft_delete', 'delete' or 'force_delete'.

We need this reverted or fixed on master before we release kilo.

Matt Riedemann (mriedem)
tags: added: api cells
Changed in nova:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Dan Smith (danms)
milestone: none → kilo-3
tags: added: kilo-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/163466

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/163466
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=75f1c57e49e9207612973c2a0be484400d6c5bcc
Submitter: Jenkins
Branch: master

commit 75f1c57e49e9207612973c2a0be484400d6c5bcc
Author: Dan Smith <email address hidden>
Date: Wed Mar 11 07:43:39 2015 -0700

    Revert "Allow force-delete irrespective of VM task_state"

    This reverts commit 222d44532c65ddf3f26532ced217890628352536.

    It changed cells RPC messaging in an incompatible way, and is also
    more complicated than we want for a backport.

    Note that this includes a change to force_delete() which calls
    self._delete() directly so that we can pass the force_delete type
    in so that the notification is named properly (and thus passes
    the current tests which expect that to be the case).

    Change-Id: Ieb00a17a23737866b7eb12481d0cb21d0f5732ba
    Closes-Bug: #1430822

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.