Error on LUN creation on HNAS iSCSI driver

[Erlon R. Cruz]

If chap_enabled is 'False', in the first initialization of the driver (before the target is created on HNAS) the driver fails to create volumes.

Steps to reproduce:
1 Set chap_enabled -> False
2 Delete the target of HNAS
3 Create a volume
4 Create an instance
5 Attach the volume to the instance.

[Jin Liu (jin-t)]

The exception log looks like in manager.py driver.initialize_connection throw exception.
There's some difference for chap_enabled=False when create volume in cinder/volume/drivers/hds/iscsi.py. If you would like add debug=true in cinder.conf and then restart cinder services, you may find more clue for the debug info generated by driver code.
And you may find something in nova-api.log, since nova run cinder-client to create volume.

[Erlon R. Cruz (sombrafam)]

Hi Jin, thanks! I have found the problem. The target name stored in the driver is not always stored correctly. It is stored as None when the target does not exist in the array. The driver then creates the target but stores None as its name. Then when it tries to attach a volume is refers to 'None' instead of the target name.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163606

[Jin Liu (jin-t)]

Good to see, another ticket https://bugs.launchpad.net/cinder/+bug/1430778 may cause by similiar reason, because I find the exception is in _attach_volume in cinder/volume/driver.py, due to initialize_connection failure.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163606
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ef27c6beb7410d7007b867b8895178245fe4b7a4
Submitter: Jenkins
Branch: master

commit ef27c6beb7410d7007b867b8895178245fe4b7a4
Author: Erlon R. Cruz <email address hidden>
Date: Wed Mar 11 11:30:28 2015 -0300

    Fix HNAS iSCSI driver error on LUN creation

    If chap_enabled is 'False', in the first initialization of the driver (before
    the target is created on HNAS) the driver fails to create volumes. This patch
    fix that by returning the right value when 'get_targetiqn' is called in this
    situation.

    Change-Id: I899717c0e7e4ff800cecc8ffa6e3a81a47e96e9f
    Closes-Bug: #1430782