fuel plugins are inconsistent when removing a plugin used by an environment

[Gil Meir]

When removing an existing plugin that is in use in an environment the rpm is uninstalled, but the API gives an error as shown below.
The problem is that on one hand the rpm was uninstalled, but since the API blocks removing the plugin from fuel backend, so the inconsistency is the rpm was removed (with the plugins files) but the plugin is still listed in fuel backend.

The rpm should be removed only if the API returned OK.

Please see the attached log.

[Gil Meir (gilmeir-d)]

Log

[Evgeniy L (rustyrobot)]

Vladimir, these two commands should be swapped https://github.com/stackforge/python-fuelclient/blob/master/fuelclient/objects/plugins.py#L324-L325

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169280

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169280
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=8a024e321d9098f2c1bc77d5ad8ea4d33f08c10f
Submitter: Jenkins
Branch: master

commit 8a024e321d9098f2c1bc77d5ad8ea4d33f08c10f
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Tue Mar 31 15:20:52 2015 +0300

    Prevent plugin package deletion before API unregister call

    If plugin has been used in some enviroment, we should show
    error and do not delete his package:

        400 Client Error: Bad Request (Can't delete plugin which is enabledfor some environment.)

    Change-Id: Id0686a6332d8312d49556fdb43c66b82b4370ef4
    Closes-Bug: #1430768

[Alexander Kurenyshev (akurenyshev)]

Steps to verify:

1) Install some plugin with package_version==2.0.0 (rpm plugin)
2) Enable it on the Fuel UI
3) Try to delete plugin with
fuel plugins --remove <plugin_name>==<plugin_version>

Observed behaviour:
Fuel shows error: 400 Client Error: Bad Request (Can't delete plugin which is enabledfor some environment.)
Plugin is still installed on the system: checked with dpkg -s <plugin_name>