netns-cleanup is broken, process_monitor parameter missing.

[Miguel Angel Ajo]

Part of a recent ProcessMonitor API refactor broke netns_cleanup.py

https://review.openstack.org/#/c/154464/13/neutron/cmd/netns_cleanup.py

Those bits need to be reverted.

[Itzik Brown (itzikb1)]

Running neutron-netns-cleanup with the force flag exits with error:

2015-03-11 14:07:22.607 ERROR neutron.cmd.netns_cleanup [-] Error unable to destroy namespace: qrouter-3baa4858-0fb7-469b-8813-83ea69d87257
2015-03-11 14:07:22.607 TRACE neutron.cmd.netns_cleanup Traceback (most recent call last):
2015-03-11 14:07:22.607 TRACE neutron.cmd.netns_cleanup File "/opt/stack/neutron/neutron/cmd/netns_cleanup.py", line 128, in destroy_namespace
2015-03-11 14:07:22.607 TRACE neutron.cmd.netns_cleanup kill_dhcp(conf, namespace)
2015-03-11 14:07:22.607 TRACE neutron.cmd.netns_cleanup File "/opt/stack/neutron/neutron/cmd/netns_cleanup.py", line 82, in kill_dhcp
2015-03-11 14:07:22.607 TRACE neutron.cmd.netns_cleanup plugin=FakeDhcpPlugin())
2015-03-11 14:07:22.607 TRACE neutron.cmd.netns_cleanup File "/usr/lib/python2.7/site-packages/oslo_utils/importutils.py", line 38, in import_object
2015-03-11 14:07:22.607 TRACE neutron.cmd.netns_cleanup return import_class(import_str)(*args, **kwargs)
2015-03-11 14:07:22.607 TRACE neutron.cmd.netns_cleanup TypeError: __init__() takes at least 4 arguments (4 given)
2015-03-11 14:07:22.607 TRACE neutron.cmd.netns_cleanup

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163401

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163401
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=59137d0ede2db20c4218e98a66a246f055451dc2
Submitter: Jenkins
Branch: master

commit 59137d0ede2db20c4218e98a66a246f055451dc2
Author: Miguel Angel Ajo <email address hidden>
Date: Wed Mar 11 12:23:20 2015 +0000

    Fix netns-cleanup broken by ProcessMonitor refactor

    Change I0da6071037f9728cc20403324e36c32116bcf00d broke the
    netns-cleanup script. As the process_monitor parameter
    is now mandatory for the dhcp driver.

    Change-Id: I69617c67815b71a05a25936c5e7acc7c116c0dd6
    Closes-bug: #1430762