Parameter mismatch of LVM volume retype

[Vincent Hou]

When migrating volumes from one type to another, the following errors raise in c-vol log, though finally the volume can be successfully migrated.

It happens on both the volumes with attach or without attach.
===========================================c-vol==================================================
2015-03-11 09:58:54.524 WARNING cinder.quota [-] Deprecated: Default quota for resource: gigabytes_lvmdriver-1 is set by the default q
uota flag: quota_gigabytes_lvmdriver-1, it is now deprecated. Please use the default quota class for default quota.
2015-03-11 09:58:54.526 WARNING cinder.quota [-] Deprecated: Default quota for resource: volumes_lvmdriver-1 is set by the default quo
ta flag: quota_volumes_lvmdriver-1, it is now deprecated. Please use the default quota class for default quota.
2015-03-11 09:58:54.586 DEBUG cinder.quota [-] Created reservations ['86bb65ed-abb9-4112-9626-1df91f4c2065', '93920a0f-c79e-4ecf-9fc0-
6f1ea7eedb0a', '5bc56a8b-f019-4b21-a924-bd656b6fffe4', '9f8a0936-97f0-4d55-9b74-4b06ac3dd748'] from (pid=12273) reserve /opt/stack/cin
der/cinder/quota.py:761
2015-03-11 09:58:54.850 ERROR cinder.volume.manager [-] Volume 137288c8-fc8f-4997-90f3-80387e49d996: driver error when trying to retyp
e, falling back to generic mechanism.
2015-03-11 09:58:54.853 ERROR cinder.volume.manager [-] retype() takes exactly 2 arguments (6 given)
2015-03-11 09:58:54.853 TRACE cinder.volume.manager Traceback (most recent call last):
2015-03-11 09:58:54.853 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 1565, in retype
2015-03-11 09:58:54.853 TRACE cinder.volume.manager host)
2015-03-11 09:58:54.853 TRACE cinder.volume.manager File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105,
in wrapper
2015-03-11 09:58:54.853 TRACE cinder.volume.manager return f(*args, **kwargs)
2015-03-11 09:58:54.853 TRACE cinder.volume.manager TypeError: retype() takes exactly 2 arguments (6 given)
2015-03-11 09:58:54.853 TRACE cinder.volume.manager
2015-03-11 09:58:55.251 DEBUG oslo_messaging._drivers.amqp [-] UNIQUE_ID is 910f9e83490e41058495c8b2dff71fed. from (pid=12273) _add_un
ique_id /usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/amqp.py:224
====================================================================================================

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163338

[OpenStack Infra (hudson-openstack)]

Change abandoned by Vincent Hou (<email address hidden>) on branch: master
Review: https://review.openstack.org/163338

[Vincent Hou (houshengbo)]

Jon Bernard has already some patches submitted to fix it.
https://review.openstack.org/#/c/162287/ and https://review.openstack.org/#/c/162288/

[Eric Harney (eharney)]

This is fallout from the abc changes, and should be fixed in the base volume driver classes, not the LVM driver. VolumeDriver should also return (False, None) like it did before, rather than raising NotImplementedError().

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/162287
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=b1ab4bb6e2db4b3232da7740a39535f1d39c6f84
Submitter: Jenkins
Branch: master

commit b1ab4bb6e2db4b3232da7740a39535f1d39c6f84
Author: Jon Bernard <email address hidden>
Date: Fri Mar 6 15:23:51 2015 -0500

    Fix retype arguments in volume driver base class

    Partial-Bug: #1430605

    Change-Id: Ida0d0d7133d88501813460ecc920f3fbd738fcc5

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/162288
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0ed77a4f7309e8391510e34a9f5ad86413f50412
Submitter: Jenkins
Branch: master

commit 0ed77a4f7309e8391510e34a9f5ad86413f50412
Author: Jon Bernard <email address hidden>
Date: Fri Mar 6 15:26:19 2015 -0500

    Fix retype return value in volume driver base class

    Instead of raising an exception, the expected behaviour is to return
    a tuple indicating that the driver does not support retype operation.

    Closes-Bug: #1430605

    Change-Id: I395dfc3213bb560767ac3fc95e5d68c4a87a7640