test_volume.VolumeTestCase not mocking out calls to execute

[Eric Harney]

master @ 490f03b Merge "Add consistency group support for XIV/DS8K cinder driver proxy"

$ ./run_tests.sh -V cinder.tests.test_volume.VolumeTestCase.test_create_volume_from_snapshot_raise_metadata_copy_failure
Running `tools/with_venv.sh python setup.py testr --testr-args='--subunit --concurrency 1 cinder.tests.test_volume.VolumeTestCase.test_create_volume_from_snapshot_raise_metadata_copy_failure'`
running testr
/home/eharney/src/cinder-trunk2/.venv/lib/python2.7/site-packages/novaclient/v1_1/__init__.py:30: UserWarning: Module novaclient.v1_1 is deprecated (taken as a basis for novaclient.v2). The preferable way to get client class or object you can find in novaclient.client module.
  warnings.warn("Module novaclient.v1_1 is deprecated (taken as a basis for "
/home/eharney/src/cinder-trunk2/.venv/lib/python2.7/site-packages/novaclient/v1_1/__init__.py:30: UserWarning: Module novaclient.v1_1 is deprecated (taken as a basis for novaclient.v2). The preferable way to get client class or object you can find in novaclient.client module.
  warnings.warn("Module novaclient.v1_1 is deprecated (taken as a basis for "
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-60} \
${PYTHON:-python} -m subunit.run discover -t ./ ./cinder/tests --list
running=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-60} \
${PYTHON:-python} -m subunit.run discover -t ./ ./cinder/tests --load-list /tmp/tmpQQf3mw
[sudo] password for eharney:

[Eric Harney (eharney)]

Seems to be introduced by:

8583aaf Snapshot of bootable volume goes in error state

https://review.openstack.org/#/q/Ic3267d422912f94e966412859e2b8bddeddfb75f,n,z

[Eric Harney (eharney)]

https://review.openstack.org/#/c/156936/2 contains the fix for this, will give the submitter a chance to propose it for master.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/163972

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/164093

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/164093
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3566ab955ec137c39e252ac77d6f31dea3fa220e
Submitter: Jenkins
Branch: master

commit 3566ab955ec137c39e252ac77d6f31dea3fa220e
Author: PranaliDeore <email address hidden>
Date: Thu Mar 12 23:47:12 2015 -0700

    Mocked utils.execute for broken tests

    Few tests were failing because utils.execute
    was not mocked.

    Added decorator @mock.patch('cinder.utils.execute')
    which will mock the utils.execute call for failing tests.

    Closes-Bug: #1430525
    Change-Id: Ib54b83b1ad6dc42b084adf48ddd53a64a9b12cf7

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eric Harney (<email address hidden>) on branch: master
Review: https://review.openstack.org/163972
Reason: Still a good idea, no progress for now though.