neutronv2 API: remove_fixed_ip_from_instance constructs a client for each port in the loop

[Matt Riedemann]

We already get a neutronclient object once at the beginning of this method when we're getting the list of ports, we don't need to get it again every time we're in the loop for the ports to update them:

http://git.openstack.org/cgit/openstack/nova/tree/nova/network/neutronv2/api.py#n803

[Matt Riedemann (mriedem)]

Same thing in add_fixed_ip_to_instance:

http://git.openstack.org/cgit/openstack/nova/tree/nova/network/neutronv2/api.py#n773

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/163181

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/163181
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7560620da7704671e6e5a304c25e506e12f213bd
Submitter: Jenkins
Branch: master

commit 7560620da7704671e6e5a304c25e506e12f213bd
Author: Matt Riedemann <email address hidden>
Date: Tue Mar 10 13:54:52 2015 -0700

    neutronv2: only create client once when adding/removing fixed IPs

    We don't need to create a neutron client object (session) every time we
    need to make an API call in add_fixed_ip_to_instance or
    remove_fixed_ip_from_instance, especially when looping over ports and
    subnets.

    Just create the client once at the beginning of the method and reuse it.

    Closes-Bug: #1430481

    Change-Id: If9181c2ef5fb94652d0205d6d69521bcc5d85cff