Dell FC Driver broken, no longer called

Bug #1430421 reported by Sean McGinnis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Sean McGinnis

Bug Description

Commit 610c672998c87e2bf2f919a4fdea86749c748a1f (https://review.openstack.org/#/c/151353/22) changed the behavior of the system that exposed a problem with the Dell Storage Center fibre channel driver.

After this commit, all third party CI test runs for this driver started failing. The overridden get_volume_stats call was not being hit, causing problems and making the backend unavailable.

Changed in cinder:
assignee: nobody → Sean McGinnis (sean-mcginnis)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/163075

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/163075
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5b7c123056b9f6b91b3a4cff776916e1ebdbfd99
Submitter: Jenkins
Branch: master

commit 5b7c123056b9f6b91b3a4cff776916e1ebdbfd99
Author: Sean McGinnis <email address hidden>
Date: Tue Mar 10 11:20:25 2015 -0500

    Dell FC driver inheritance order causing failures

    After commit 610c672998c87e2bf2f919a4fdea86749c748a1f merged
    the third party CI test runs for the Dell Storage Center fibre
    channel driver started failing. This appeared to be a change
    in get_volume_stats calls.

    After isolating the cause of this problem it was identified
    that the order of the inherited classes for the driver was
    resulting in the wrong overridden get_volume_stats call to be
    called.

    This patch fixes this be just switching the order of the two
    parent classes DellCommonDriver and FibreChannelDriver. Swapping
    these two results in the correctly overridden call to be made
    and CI tests to pass successfully.

    Change-Id: I58ec1fde585179037aeca8d449e74d0333fb013d
    Closes-Bug: 1430421

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.