linuxbridge UTs need more mocking

Bug #1430098 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
YAMAMOTO Takashi

Bug Description

after commit b7a56fd1b44649daa1f768157e68a135b9e01dd1 ,
some of linuxbridge UTs seem trying to run ip command and failes if it isn't available.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/162825

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/162826

Changed in neutron:
importance: Undecided → Medium
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/162825
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=34008eb55409d6ff2732da045246a84f144044c4
Submitter: Jenkins
Branch: master

commit 34008eb55409d6ff2732da045246a84f144044c4
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Mar 10 10:23:53 2015 +0900

    linuxbridge UT: Do not create the same instance in each cases

    Reuse the one created by setUp() instead.

    Related-Bug: #1430098
    Change-Id: I2cf1123c66a81ad967507a2fefb89c306cdb28bb

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/162826
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ce0b13982158d813024cad1fae7f495e3545b7ee
Submitter: Jenkins
Branch: master

commit ce0b13982158d813024cad1fae7f495e3545b7ee
Author: YAMAMOTO Takashi <email address hidden>
Date: Tue Mar 10 10:12:50 2015 +0900

    linuxbridge UT: Mock get_interface_by_ip

    To avoid querying devices on the system running UT,
    which might or might not work.

    The regression was introduced by
    commit b7a56fd1b44649daa1f768157e68a135b9e01dd1 .

    Closes-Bug: #1430098
    Change-Id: I2dcdf4b9516e0a90dffee26684fdce7f0ce43cd8

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.