Improve security rule notification message

[Kahou Lei]

If we create a rule that allow all ports to go thru, we are displaying the following notification message (see attached image too):

Successfully added rule:
-1:-1/icmp from 0.0.0.0/0

where -1:-1 doesn't deliver useful information.

Suggest to change -1:-1 to "any port" instead.

[Rob Cresswell (robcresswell-deactivatedaccount)]

I can't recreate this in master; could you provide more information?

[BassT (mt104b)]

Tested out all the different rules that applies to all ports on master. The message mentioned above has changed. The closest to it is the message when creating a rule for all ICMP where the message is

Successfully added rule:
-1:-1/icmp from 0.0.0.0/0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/313086

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/313610

[OpenStack Infra (hudson-openstack)]

Change abandoned by Yosef Hoffman (<email address hidden>) on branch: master
Review: https://review.openstack.org/313610
Reason: Duplicate of https://review.openstack.org/#/c/313086/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/313086
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9a535a1f848c7813169fdd7d042a29678c554092
Submitter: Jenkins
Branch: master

commit 9a535a1f848c7813169fdd7d042a29678c554092
Author: Yosef Hoffman <email address hidden>
Date: Thu May 5 11:12:23 2016 -0400

    Improve security rule notification message

    If from_port and to_port are both "-1" then return "any port"
    instead of "-1:-1". For example, instead of
     ``ALLOW -1:-1/icmp from 0.0.0.0/0``
    return
     ``ALLOW any port/icmp from 0.0.0.0/0``

    Change-Id: I0ded50a40089406fd69c8fa869839e46eecef352
    Closes-Bug: #1430005

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 10.0.0.0rc1 release candidate.