non-string choices for StrOpt break config generator

Bug #1429981 reported by Doug Hellmann
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
oslo.config
Fix Released
Critical
Davanum Srinivas (DIMS)

Bug Description

Some projects, like tempest, register None as an option for a StrOpt instance that presents a choice. This breaks the configuration file generator.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :
Changed in oslo.config:
milestone: none → next-kilo
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
importance: Undecided → Critical
status: New → Triaged
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :
Changed in oslo.config:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.config (master)

Reviewed: https://review.openstack.org/162728
Committed: https://git.openstack.org/cgit/openstack/oslo.config/commit/?id=9db52476f67ac1d66510c80c2e41e8bc3d653adf
Submitter: Jenkins
Branch: master

commit 9db52476f67ac1d66510c80c2e41e8bc3d653adf
Author: Davanum Srinivas <email address hidden>
Date: Mon Mar 9 15:07:44 2015 -0400

    None in config choices breaks oslo-config-generator

    Tempest using StrOpt with choices
    choices=[None, 'normal', 'direct', 'macvtap']

    And oslo-config-generator does not like it. We need to
    print "<None>" when we encounter None as a choice.

    Closes-Bug: #1429981
    Change-Id: I3bb3621420915a6a2990440294a389b45a23c519

Changed in oslo.config:
status: In Progress → Fix Committed
Changed in oslo.config:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.