Wrong mock assert methods

Bug #1429669 reported by Thang Pham
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Thang Pham

Bug Description

Several cinder test cases are using the wrong mock assert methods, e.g. assert_called() or assert_once_called_with(). A check should be added to fix this, so that these wrong mock asserts are no longer getting into the test cases. This has been done in nova -(https://github.com/openstack/nova/blob/master/nova/test.py#L153) and should be done in cinder.

Thang Pham (thang-pham)
Changed in cinder:
assignee: nobody → Thang Pham (thang-pham)
Changed in cinder:
status: New → In Progress
Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/160208
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a9b9d53a2fe86d90587053ece8b26b9ae2fdf3fb
Submitter: Jenkins
Branch: master

commit a9b9d53a2fe86d90587053ece8b26b9ae2fdf3fb
Author: Thang Pham <email address hidden>
Date: Sun Mar 1 19:43:58 2015 -0500

    Raise exception for invalid mock assert calls

    Several test cases were using the wrong mock assert methods.
    The following patch corrects these calls and adds a method in
    test.py (sourced from nova/test.py) to make sure they are
    properly caught in the future.

    Closes-Bug: #1429669
    Change-Id: Ic6e5bca0c3ddbfb402e412b51e882859cb49108c

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.