Ironic should use labels for virtual media floppy images

Bug #1429340 reported by Ramakrishnan G (rameshg87)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Undecided
Ramakrishnan G (rameshg87)
diskimage-builder
Fix Released
Medium
Ramakrishnan G (rameshg87)

Bug Description

Ironic should use labels for virtual media floppy images. This will enable ramdisks (DIB and Agent) to identify the block device using labels. This can be used as a common technique for identifying the virtual media floppy image irrespective of the hardware.

Changed in ironic:
assignee: nobody → Ramakrishnan G (rameshg87)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/162387

Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-python-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/162392

Changed in diskimage-builder:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/162387
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d5e6b713526063e4820f552a5ef3ac9d92326d3a
Submitter: Jenkins
Branch: master

commit d5e6b713526063e4820f552a5ef3ac9d92326d3a
Author: Ramakrishnan G <email address hidden>
Date: Fri Mar 6 15:42:42 2015 +0000

    Add label to virtual floppy image

    This commit adds a label "ir-vfd-dev" to the
    virtual floppy image that is created by Ironic
    for virtual media deploy. This helps ramdisks to find
    the partition by using /dev/disk/by-label/ir-vfd-dev.

    Closes-Bug: #1429340
    Change-Id: If5b78d9af7048f2631d050ee5ce01ab7a67e2354

Changed in ironic:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-python-agent (master)

Reviewed: https://review.openstack.org/162392
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=d0d319d65fd7343f2b9142ca9e92876a13dd583d
Submitter: Jenkins
Branch: master

commit d0d319d65fd7343f2b9142ca9e92876a13dd583d
Author: Ramakrishnan G <email address hidden>
Date: Thu Mar 12 04:14:11 2015 +0000

    Use labels for virtual media dev in agent ramdisk

    This commit changes agent deploy ramdisk to find out
    the virtual media device by using labels instead of
    looking at the model of block device. This helps in
    finding out the device irrespective of the hardware.

    Corresponding Ironic change is
    If5b78d9af7048f2631d050ee5ce01ab7a67e2354.

    Closes-Bug: 1429340
    Change-Id: Ib6cc226dc4fb341d913f707737493c31a3f77152

Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to diskimage-builder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/175104

Changed in diskimage-builder:
assignee: nobody → Ramakrishnan G (rameshg87)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to diskimage-builder (master)

Reviewed: https://review.openstack.org/175104
Committed: https://git.openstack.org/cgit/openstack/diskimage-builder/commit/?id=1540e753dc7f482f442ce9588eb917d2538f81ee
Submitter: Jenkins
Branch: master

commit 1540e753dc7f482f442ce9588eb917d2538f81ee
Author: Ramakrishnan G <email address hidden>
Date: Fri Mar 6 15:51:58 2015 +0000

    Use labels for virtual media dev in Ironic ramdisk

    This commit changes Ironic deploy ramdisk to find out
    the virtual media device by using labels instead of
    looking at the model of block device. This helps in
    finding out the device irrespective of the hardware.
    Corresponding Ironic change is
    If5b78d9af7048f2631d050ee5ce01ab7a67e2354.

    Closes-Bug: #1429340
    Change-Id: I5e8a706989bad13051eb47db0b1e762e6c672318

Changed in diskimage-builder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-3 → 2015.1.0
Jay Dobies (jdob)
Changed in diskimage-builder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.