Duplicate volumes detail request on find_resource

Bug #1429102 reported by Gorka Eguileor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Low
Gorka Eguileor

Bug Description

utils.find_resource has a duplicate find request by display_name and this affects any command that searches for a volume by display_name or any command that searches for non existent volumes.

You can see this by running
   cinder --debug show fake_disk_name

You will see that you get 4 request to volumes/detail?all_tenants=1
And there should only be 3, by:
- human_id
- name
- display_name

But display_name is tried twice.

Gorka Eguileor (gorka)
Changed in python-cinderclient:
assignee: nobody → Gorka Eguileor (gorka)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/162130

Mike Perez (thingee)
Changed in python-cinderclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/162130
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4
Submitter: Jenkins
Branch: master

commit 6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4
Author: Gorka Eguileor <email address hidden>
Date: Fri Mar 6 13:13:05 2015 +0100

    Remove duplicate find request in find_resource

    Removed duplicate manager.find method call using search argument
    display_name that affected any command that searches for a volume by
    display_name or any command that searches for non existent volumes.

    Change-Id: I86c99b41dd231b058ed3f6d5d78eafe35a111dec
    Closes-Bug: #1429102

Changed in python-cinderclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.