show fails on numeric and UUID like display-names

Bug #1428764 reported by Gorka Eguileor
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Medium
Tushar Patil

Bug Description

On volumes created with a numeric or UUID like display name show sub-command fails to retrieve and display information.

To test this:
cinder create --display-name 1 1
cinder show 1

The issue is with the exception returned by client.SessionClient that is keystoneclient.openstack.common.apiclient.exceptions.NotFound instead of cinderclient.exceptions.NotFound because we are inheriting from keystoneclient.

Gorka Eguileor (gorka)
Changed in python-cinderclient:
assignee: nobody → Gorka Eguileor (gorka)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/161862

Changed in python-cinderclient:
assignee: Gorka Eguileor (gorka) → Tushar Patil (tpatil)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-cinderclient (master)

Change abandoned by Gorka Eguileor (<email address hidden>) on branch: master
Review: https://review.openstack.org/161862
Reason: Patch https://review.openstack.org/#/c/166351/ solves same issue with a neater implementation.

Jay Bryant (jsbryant)
Changed in python-cinderclient:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/166351
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=de36755657bb0c498c6cfe06b05052aff2e0d400
Submitter: Jenkins
Branch: master

commit de36755657bb0c498c6cfe06b05052aff2e0d400
Author: tpatil <email address hidden>
Date: Fri Mar 20 12:17:53 2015 -0700

    Allow cinderclient to handle exception response

    For all cinder commands, the error message returned by the cinder
    service is gobbled by keystoneclient as raise_exc is enabled by
    default and it doesn't have the knowledge of how to interpret
    exception returned by the cinder service correctly.

    Set raise_exc to False explicitly in request method of cinderclient
    and pass it to the keystoneclient session request method so that
    keystoneclient raises exception only when the exception is raised
    by the keystone server else cinderclient should interpret the
    exception returned by the cinder service.

    Closes-Bug: 1431693
    Closes-Bug: 1428764
    Change-Id: I1160a2c998919b669c39a4b739e83f5bd9d8d235

Changed in python-cinderclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.